From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH 1/2] Fix "git diff" setup code Date: Fri, 14 Sep 2007 11:30:53 -0700 (PDT) Message-ID: References: <20070905234941.GA643@nomad.office.altlinux.org> <20070906022539.GG18160@spearce.org> <20070906101648.GD6665@basalt.office.altlinux.org> <20070909044648.GH18160@spearce.org> <7vir6fjmuv.fsf@gitster.siamese.dyndns.org> <20070913035137.GM3099@spearce.org> <7vr6l2gxyw.fsf@gitster.siamese.dyndns.org> <20070914000108.GE3619@basalt.office.altlinux.org> <7vr6l2f6k1.fsf@gitster.siamese.dyndns.org> <20070914024303.GH3619@basalt.office.altlinux.org> <7v4phxaz3o.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Cc: "Dmitry V. Levin" , "Shawn O. Pearce" , Git Mailing List , Jeff King To: Junio C Hamano X-From: git-owner@vger.kernel.org Fri Sep 14 20:38:30 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IWFws-0006g4-Kh for gcvg-git-2@gmane.org; Fri, 14 Sep 2007 20:31:27 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754926AbXINSbX (ORCPT ); Fri, 14 Sep 2007 14:31:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754254AbXINSbW (ORCPT ); Fri, 14 Sep 2007 14:31:22 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:60956 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753971AbXINSbW (ORCPT ); Fri, 14 Sep 2007 14:31:22 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [207.189.120.55]) by smtp2.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id l8EIUkNV017520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 14 Sep 2007 11:30:47 -0700 Received: from localhost (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id l8EIUkgU018604; Fri, 14 Sep 2007 11:30:46 -0700 In-Reply-To: <7v4phxaz3o.fsf@gitster.siamese.dyndns.org> X-Spam-Status: No, hits=-3.239 required=5 tests=AWL,BAYES_00,OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.1.0-osdl_revision__1.34__ X-MIMEDefang-Filter: lf$Revision: 1.185 $ X-Scanned-By: MIMEDefang 2.53 on 207.189.120.14 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: On Fri, 14 Sep 2007, Junio C Hamano wrote: > > So I tend to think the attached is a better fix. Ahh, yes, that explains the conditional. But whatever gets us to actually verify our options, and fill in the right defaults is ok by me! Linus