git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alex Riesen <raa.lkml@gmail.com>,
	Robin Rosenberg <robin.rosenberg.lists@dewire.com>,
	Michal Rokos <michal.rokos@gmail.com>, GIT <git@vger.kernel.org>
Subject: Re: index-pack died on pread
Date: Thu, 26 Jul 2007 22:36:16 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0707262231280.3442@woody.linux-foundation.org> (raw)
In-Reply-To: <7vps2e5x4y.fsf@assigned-by-dhcp.cox.net>



On Thu, 26 Jul 2007, Junio C Hamano wrote:
> 
> If you mean the offset associated with fd, we actually do.

Ahh, for some reason I thought we didn't (probably because the user likely 
doesn't care at all), but right you are..

> The original HP-UX error is confusing, as we ask pread() to
> transfer 428 bytes and it returns 0 (not returning -1 with
> EINTR).  Return value of zero is understandable, if the starting
> position is at or after the EOF, but the offset is 123601 and
> 56k objects packed from git.git repository should be longer than
> that, so that also sounds implausible.

Yeah. It is suspicious.

If somebody could run git under gdb on HP-UX (preferably compiled 
statically), and just disassemble the pread() thing, it would be 
interesting.

PA-RISC assembly is *almost* entirely unreadable, but it might show 
whether hpux-11.11 actually has a pread() system call or whether it is 
doing the "emulate with lseek" and maybe obviously buggily at that..

It really isn't that complex a system call. So I'm surprised at bugs 
there, and that makes me worry that there is something in git that 
triggers this.

		Linus

  reply	other threads:[~2007-07-27  5:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-23 12:52 index-pack died on pread Michal Rokos
2007-07-23 15:32 ` Alex Riesen
2007-07-25 20:07   ` Michal Rokos
2007-07-25 20:48     ` Alex Riesen
2007-07-23 17:04 ` Linus Torvalds
2007-07-23 18:03   ` Nicolas Pitre
2007-07-25 23:15   ` Robin Rosenberg
2007-07-25 23:44     ` Linus Torvalds
2007-07-26 12:42       ` Alex Riesen
2007-07-26 16:13         ` Linus Torvalds
2007-07-26 16:51           ` Alex Riesen
2007-07-26 18:02             ` Linus Torvalds
2007-07-27  3:43           ` Junio C Hamano
2007-07-27  5:36             ` Linus Torvalds [this message]
2007-07-27  9:50               ` Tomash Brechko
2007-07-27 10:33                 ` Tomash Brechko
2007-07-27 13:38               ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0707262231280.3442@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=michal.rokos@gmail.com \
    --cc=raa.lkml@gmail.com \
    --cc=robin.rosenberg.lists@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).