From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Nicolas Pitre <nico@cam.org>, git@vger.kernel.org
Subject: Re: [RFH] WTF did we change in git-fsck recently?
Date: Fri, 20 Apr 2007 18:30:06 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.98.0704201826350.9964@woody.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.0.98.0704201823310.9964@woody.linux-foundation.org>
On Fri, 20 Apr 2007, Linus Torvalds wrote:
>
> Hmm. Probably something broken in my "object decorator" thing then.
Duh.
When I did the object decorator thing, I made the "loop over the hash"
function use the same logic for updating the hash, ie made them use
if (++j >= size)
j = 0;
for both the hash update for both "insert" and "lookup"
HOWEVER.
For some inexplicable reason I had an extraneous
j++;
in the insert path (probably just from the fact that the old code there
used
j++;
if (j >= size)
j = 0;
and when I made them use the same logic I just didn't remove the old
extraneous line properly.
This fixes it.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
decorate.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/decorate.c b/decorate.c
index 396b413..23f6b00 100644
--- a/decorate.c
+++ b/decorate.c
@@ -24,7 +24,6 @@ static void *insert_decoration(struct decoration *n, struct object *base, void *
hash[j].decoration = decoration;
return old;
}
- j++;
if (++j >= size)
j = 0;
}
next prev parent reply other threads:[~2007-04-21 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-21 0:30 [RFH] WTF did we change in git-fsck recently? Junio C Hamano
2007-04-21 1:24 ` Linus Torvalds
2007-04-21 1:30 ` Linus Torvalds [this message]
2007-04-21 2:17 ` Junio C Hamano
2007-04-21 20:36 ` Automated bisect success story Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.98.0704201826350.9964@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).