git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Isaac Shabtay <isaac@shabtay.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: Bug report: git clone with dest
Date: Fri, 5 Jan 2018 11:33:39 +0100 (STD)	[thread overview]
Message-ID: <alpine.DEB.2.21.1.1801051130500.32@MININT-6BKU6QN.europe.corp.microsoft.com> (raw)
In-Reply-To: <CAK2k7nTRAqQKFGi0OfVgub3vWZAkdML5p786L7UyhVDFtsk7Xg@mail.gmail.com>

Hi Isaac,

On Thu, 4 Jan 2018, Isaac Shabtay wrote:

> I cloned git's codebase, applied the four patches on master, built and
> tested on Ubuntu Trusty. (After verifying that master indeed exhibits
> this behaviour on Linux as well. Just checking).
> Seems to work fine.
> I also looked at the code. Most of the patched lines relate to tests,
> and the one for clone.c seems reasonable to me. Added tests seem to
> have very good coverage too.

Thanks.

> I qualify everything I had written above by saying that it's my first
> time ever looking at Git's source code.

We all started at some point.

Now, if you want to make this easier for me, could you please apply those
patches on top of Git for Windows' master branch and open a Pull Request
at https://github.com/git-for-windows/git?

Thank you,
Johannes

  reply	other threads:[~2018-01-05 10:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03 20:59 Bug report: git clone with dest Isaac Shabtay
2018-01-03 22:28 ` Jeff King
2018-01-03 22:44   ` Isaac Shabtay
2018-01-04 23:20     ` Johannes Schindelin
2018-01-05  5:11       ` Isaac Shabtay
2018-01-05 10:33         ` Johannes Schindelin [this message]
2018-01-05 18:55           ` Isaac Shabtay
2018-01-05 20:22             ` Johannes Schindelin
2018-01-05 20:38               ` Junio C Hamano
2018-01-05 20:44               ` Jeff King
2018-01-05 21:39                 ` Johannes Schindelin
     [not found]   ` <CAK2k7nQcY+QQBfda6CHM8tFo3i4XX2tXxHKv73t6SJ4rRvWo1w@mail.gmail.com>
2018-01-04  4:01     ` Jeff King
2018-01-05 19:53       ` Junio C Hamano
2018-01-05 19:57         ` Jeff King
2018-01-05 20:45           ` Junio C Hamano
2018-01-05 20:52             ` Jeff King
2018-01-05 22:37               ` Junio C Hamano
2018-01-06  4:43                 ` Jeff King
2018-01-05 21:06         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1.1801051130500.32@MININT-6BKU6QN.europe.corp.microsoft.com \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=isaac@shabtay.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).