git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Kevin A. Mitchell" <kam@kamit.com>
Cc: git@vger.kernel.org
Subject: Re: Bug/feature request: Can’t disable fsck warnings during clone
Date: Thu, 4 Jan 2018 21:28:21 +0100 (STD)	[thread overview]
Message-ID: <alpine.DEB.2.21.1.1801042125430.32@MININT-6BKU6QN.europe.corp.microsoft.com> (raw)
In-Reply-To: <CAF1p0HimkxVydxL3cfRXX0=oaBrmARzYqCbqiarWn1yvh+H-EA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2653 bytes --]

Hi Kevin,

On Thu, 28 Dec 2017, Kevin A. Mitchell wrote:

> I’ve set transfer.fsckObjects to true globally, for safety.
> Unfortunately, this messed up my Spacevim install.
> 
> Doing some digging, I found that some of the repos had a warning. I
> can turn the warning off, but that only affects git fsck, not git
> clone. Turning off transfer.fsckObjects also fixes the problem. I’d
> rather have it on for my development work.
> 
> Tested with the “next” branch as well.
> 
> $ git -c transfer.fsckObjects=true -c fsck.zeroPaddedFilemode=ignore
> clone https://github.com/albfan/ag.vim
> Cloning into 'ag.vim'...
> remote: Counting objects: 1879, done.
> error: object 65e1a0027644b6625b32d30ba5ccf1c4d483480a:
> zeroPaddedFilemode: contains zero-padded file modes
> fatal: Error in object
> fatal: index-pack failed
> $ git —version
> git version 2.15.1.501.g29533fb16
> 
> but this works as expected:
> 
> $ git clone https://github.com/albfan/ag.vim
> Cloning into 'ag.vim'...
> remote: Counting objects: 1879, done.
> remote: Total 1879 (delta 0), reused 0 (delta 0), pack-reused 1879
> Receiving objects: 100% (1879/1879), 1.23 MiB | 2.76 MiB/s, done.
> Resolving deltas: 100% (938/938), done.
> $ cd ag.vim
> $ git -c transfer.fsckObjects=true -c fsck.zeroPaddedFilemode=ignore fsck
> Checking object directories: 100% (256/256), done.
> Checking objects: 100% (1879/1879), done.
> $ git -c transfer.fsckObjects=true fsck
> Checking object directories: 100% (256/256), done.
> warning in tree 65e1a0027644b6625b32d30ba5ccf1c4d483480a:
> zeroPaddedFilemode: contains zero-padded file modes
> Checking objects: 100% (1879/1879), done.
> 
> It would be useful to be able to turn off individual warnings during
> cloning. Is there something I’m missing in the config? Or, is this
> something that could be fixed?

Well, you can apparently have your cake and eat it too (see
https://git-scm.com/docs/git-config#git-config-receivefsckltmsg-idgt):

receive.fsck.<msg-id>::
        When `receive.fsckObjects` is set to true, errors can be switched
        to warnings and vice versa by configuring the `receive.fsck.<msg-id>`
        setting where the `<msg-id>` is the fsck message ID and the value
        is one of `error`, `warn` or `ignore`. For convenience, fsck prefixes
        the error/warning with the message ID, e.g. "missingEmail: invalid
        author/committer line - missing email" means that setting
        `receive.fsck.missingEmail = ignore` will hide that issue.

In your case, use receive.fsck.zeroPaddedFilemode=ignore=warn (or
=ignore).

Ciao,
Johannes

      reply	other threads:[~2018-01-04 20:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-28 15:51 Bug/feature request: Can’t disable fsck warnings during clone Kevin A. Mitchell
2018-01-04 20:28 ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1.1801042125430.32@MININT-6BKU6QN.europe.corp.microsoft.com \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=kam@kamit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).