From: Johannes Schindelin <Johannes.Schindelin@gmx.de> To: Dan Jacques <email@example.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v3 4/4] exec_cmd: RUNTIME_PREFIX on some POSIX systems Date: Tue, 28 Nov 2017 15:08:53 +0100 (CET) [thread overview] Message-ID: <alpine.DEB.188.8.131.521281330150.6482@virtualbox> (raw) In-Reply-To: <email@example.com> Hi Dan, and (based on the timezone recorded in your mail:) good morning! On Mon, 27 Nov 2017, Dan Jacques wrote: > > In Git for Windows, we have an almost identical patch: > > > > https://github.com/git-for-windows/git/commit/bdd739bb2b0b > > > > We just guard the call to system_path() behind a test whether podir is > > already absolute, but these days, system_path() does that itself. > > > > I am too little of a Perl expert to be helpful with the other patches, but > > I would gladly runa build & test on Windows if you direct me to an > > easily-pullable branch. > > Oh interesting - I've only peripherally looked at Git-for-Windows code, > since Chromium uses its packages verbatim (thanks, BTW!). I think you're > correct though - this patch set seems to be doing the same thing. Excellent, thanks for confirming. > I've been force-pushing my changes to the "runtime-prefix" branch of my > Git fork for travis.ci testing. The latest commit on that branch adds a > "config.mak" for testing, so one commit from the branch head will > contain the sum set of this patch series applied at (or near) Git's > master branch: > > https://github.com/danjacques/git/tree/runtime-prefix~1 > > Let me know if this is what you are looking for, and if I can offer any > help with Windows testing. Thanks! Thank you, that was exactly what I was looking for. BTW I think that your config.mak settings are partially unnecessary: the gitexecdir and template_dir should be identical, and sysconfdir, too (at least unless you override prefix). I triggered a build (with the config.mak commit, because it does not really matter), and it failed immediately due to a quoting issue: the path separator is a semicolon on Windows and therefore must be quoted (so that it is not misinterpreted as ending the command). There were a couple of other issues, too, and I opened a PR here: https://github.com/danjacques/git/pull/1 Ciao, Dscho
prev parent reply other threads:[~2017-11-28 14:09 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-27 16:40 [PATCH v3 0/4] RUNTIME_PREFIX relocatable Git Dan Jacques 2017-11-27 16:40 ` [PATCH v3 1/4] Makefile: generate Perl header from template file Dan Jacques 2017-11-27 16:40 ` [PATCH v3 2/4] Makefile: add support for "perllibdir" Dan Jacques 2017-11-27 16:40 ` [PATCH v3 3/4] Makefile: add Perl runtime prefix support Dan Jacques 2017-11-27 16:40 ` [PATCH v3 4/4] exec_cmd: RUNTIME_PREFIX on some POSIX systems Dan Jacques 2017-11-27 23:42 ` Johannes Schindelin 2017-11-28 3:25 ` Dan Jacques 2017-11-28 3:47 ` Junio C Hamano 2017-11-28 11:36 ` Johannes Schindelin 2017-11-29 1:38 ` Question regarding "next" merge Dan Jacques 2017-11-29 2:18 ` Junio C Hamano 2017-11-28 14:08 ` Johannes Schindelin [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.184.108.40.2061281330150.6482@virtualbox \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v3 4/4] exec_cmd: RUNTIME_PREFIX on some POSIX systems' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).