From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Alex Vandiver <alexmv@dropbox.com>
Cc: git@vger.kernel.org, Ben Peart <peartben@gmail.com>
Subject: Re: [PATCH 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman
Date: Fri, 20 Oct 2017 15:00:40 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1.1710201459020.40514@virtualbox> (raw)
In-Reply-To: <6887851348e177728849964cc95ae783b0feb971.1508461850.git.alexmv@dropbox.com>
Hi Alex,
On Thu, 19 Oct 2017, Alex Vandiver wrote:
> This provides small performance savings.
>
> diff --git a/t/t7519/fsmonitor-watchman b/t/t7519/fsmonitor-watchman
> index 377edc7be..eba46c78b 100755
> --- a/t/t7519/fsmonitor-watchman
> +++ b/t/t7519/fsmonitor-watchman
> @@ -51,7 +51,7 @@ launch_watchman();
>
> sub launch_watchman {
>
> - my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j')
> + my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j --no-pretty')
While I am very much infavor of this change (I was not aware of the
--no-pretty option), I would like to see some statistics on that. Could
you measure the impact, please, and include the results in the commit
message?
Ciao,
Johannes
next prev parent reply other threads:[~2017-10-20 13:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 1:11 [PATCH 0/4] fsmonitor fixes Alex Vandiver
2017-10-20 1:11 ` [PATCH 1/4] fsmonitor: Watch, and ask about, the top of the repo, not the CWD Alex Vandiver
2017-10-20 1:11 ` [PATCH 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman Alex Vandiver
2017-10-20 13:00 ` Johannes Schindelin [this message]
2017-10-20 13:17 ` Ben Peart
2017-10-26 0:44 ` Alex Vandiver
2017-10-27 15:13 ` Johannes Schindelin
2017-10-20 1:11 ` [PATCH 3/4] fsmonitor: Document GIT_TRACE_FSMONITOR Alex Vandiver
2017-10-20 13:19 ` Ben Peart
2017-10-20 1:11 ` [PATCH 4/4] fsmonitor: Delay updating state until after split index is merged Alex Vandiver
2017-10-20 13:16 ` Johannes Schindelin
2017-10-20 21:47 ` Ben Peart
2017-10-21 2:06 ` Junio C Hamano
2017-10-21 3:35 ` Jeff King
2017-10-23 9:57 ` Johannes Schindelin
2017-10-23 12:36 ` Ben Peart
2017-10-26 1:20 ` Alex Vandiver
2017-10-20 12:58 ` [PATCH 1/4] fsmonitor: Watch, and ask about, the top of the repo, not the CWD Johannes Schindelin
2017-10-26 0:20 ` Alex Vandiver
2017-10-27 15:11 ` Johannes Schindelin
2017-10-20 13:17 ` [PATCH 0/4] fsmonitor fixes Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1.1710201459020.40514@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=alexmv@dropbox.com \
--cc=git@vger.kernel.org \
--cc=peartben@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).