From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 09E1D1F4B4 for ; Wed, 14 Oct 2020 09:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730811AbgJNJYh (ORCPT ); Wed, 14 Oct 2020 05:24:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730801AbgJNJUK (ORCPT ); Wed, 14 Oct 2020 05:20:10 -0400 Received: from giant.haxx.se (www.haxx.se [IPv6:2a00:1a28:1200:9::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C52F2C061755 for ; Tue, 13 Oct 2020 14:17:17 -0700 (PDT) Received: from giant.haxx.se (mail [127.0.0.1]) by giant.haxx.se (8.15.2/8.15.2/Debian-4) with ESMTPS id 09DLH0g8004983 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Oct 2020 23:17:00 +0200 Received: from localhost (dast@localhost) by giant.haxx.se (8.15.2/8.15.2/Submit) with ESMTP id 09DLGw4u004963; Tue, 13 Oct 2020 23:16:59 +0200 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Tue, 13 Oct 2020 23:16:58 +0200 (CEST) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: Jeff King cc: Junio C Hamano , Sean McAllister , git@vger.kernel.org, masayasuzuki@google.com, jrnieder@gmail.com Subject: Re: [PATCH v2 2/3] replace CURLOPT_FILE With CURLOPT_WRITEDATA In-Reply-To: <20201013205841.GA3678071@coredump.intra.peff.net> Message-ID: References: <20201013191729.2524700-1-smcallis@google.com> <20201013191729.2524700-2-smcallis@google.com> <20201013205841.GA3678071@coredump.intra.peff.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) X-fromdanielhimself: yes MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, 13 Oct 2020, Jeff King wrote: Let me just inject myself here and comment on two curl things. > - when is _FILE going away (or has it already in some versions)? It will be kept around *at least* for as long as libcurl supports the version 7 API: for the forseeable future. Posssibly decades. > - when did _WRITEDATA appear? All curl symbols ever introduced are documented clearly in which version they appeared. See: https://curl.haxx.se/libcurl/c/symbols-in-versions.html To map the version numbers to release dates, this second table comes handy: https://curl.haxx.se/docs/releases.html CURLOPT_WRITEDATA was added in curl 7.9.7, shipped on May 10 2002. In the curl project we often see users use *very* old versions but 18 years is longer than even the most conservative users I've seen... -- / daniel.haxx.se (with my curl hat on)