From: Daniel Stenberg <daniel@haxx.se>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brandon Williams <bmwill@google.com>,
git@vger.kernel.org, jrnieder@gmail.com, sbeller@google.com
Subject: Re: [PATCH v2 1/2] remote-curl: accept all encodings supported by curl
Date: Wed, 23 May 2018 07:55:19 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1805230751370.6210@tvnag.unkk.fr> (raw)
In-Reply-To: <xmqqwovvw4fl.fsf@gitster-ct.c.googlers.com>
On Wed, 23 May 2018, Junio C Hamano wrote:
>> -> Accept-Encoding: gzip
>> +> Accept-Encoding: ENCODINGS
>
> Is the ordering of these headers determined by the user of cURL library
> (i.e. Git), or whatever the version of cURL we happened to link with happens
> to produce?
>
> The point is whether the order is expected to be stable, or we are better
> off sorting the actual log before comparing.
The order is not guaranteed by libcurl to be fixed, but it is likely to remain
stable since we too have test cases and compare outputs with expected outputs!
=)
Going forward, brotli (br) is going to become more commonly present in that
header.
--
/ daniel.haxx.se
prev parent reply other threads:[~2018-05-23 5:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 23:40 [PATCH 1/2] remote-curl: accept all encoding supported by curl Brandon Williams
2018-05-21 23:40 ` [PATCH 2/2] remote-curl: accept compressed responses with protocol v2 Brandon Williams
2018-05-22 0:01 ` [PATCH 1/2] remote-curl: accept all encoding supported by curl Jonathan Nieder
2018-05-26 11:08 ` anton.golubev
2018-05-22 0:02 ` Stefan Beller
2018-05-22 1:00 ` Jonathan Nieder
2018-05-22 6:32 ` Daniel Stenberg
2018-05-22 18:40 ` Brandon Williams
2018-05-22 18:42 ` [PATCH v2 1/2] remote-curl: accept all encodings " Brandon Williams
2018-05-22 18:42 ` [PATCH v2 2/2] remote-curl: accept compressed responses with protocol v2 Brandon Williams
2018-05-22 18:55 ` Jonathan Nieder
2018-05-22 18:48 ` [PATCH v2 1/2] remote-curl: accept all encodings supported by curl Jonathan Nieder
2018-05-23 1:23 ` Junio C Hamano
2018-05-23 2:17 ` brian m. carlson
2018-05-23 5:55 ` Daniel Stenberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1805230751370.6210@tvnag.unkk.fr \
--to=daniel@haxx.se \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).