git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Ivan Tham <pickfire@riseup.net>
Cc: Stefan Beller <sbeller@google.com>, git@vger.kernel.org
Subject: Re: Re: GSoC Project | Convert interactive rebase to C
Date: Thu, 23 Mar 2017 18:30:35 +0100 (CET)
Message-ID: <alpine.DEB.2.20.1703231827060.3767@virtualbox> (raw)
In-Reply-To: <20170321060526.sXz0cdJwc%pickfire@riseup.net>

Hi Ivan,

On Tue, 21 Mar 2017, Ivan Tham wrote:

> Stefan Beller <sbeller@google.com> wrote:
> > On Mon, Mar 20, 2017 at 9:41 AM, Ivan Tham <pickfire@riseup.net> wrote:
> > > I am Ivan Tham. Currently studying in Computer Science in APIIT
> > > Malaysia. I am interested particapate in Google Summer of Code 2017
> > > under git organization. I would like to attempt "Add more builtin
> > > patterns for userdiff" particularly for shell for my microproject.
> >
> > I'd love to see proper shell support!  Although there is already some
> > support for shell (by looking at diffs on our test suite) ? So I am
> > not sure what there is left to do? Can you clarify what you're trying
> > there?
> 
> Are you sure about that? From what I had looked into userdiff.c, there
> is no support for shell. There just a recent patch for [go patterns][0].
> Or perhaps I should have rename it as "userdiff.c: patterns for "shell"
> language"?

I also could not find any shell patterns in the userdiff code...

> > > I am interested to work on "Convert interactive rebase to C"
> >
> > +cc Johannes, who recently worked on rebase and the sequencer.

Glad you are interested! Please note that large parts of the interactive
rebase are already in C now, but there is enough work left in that corner.

> > > aiming to port most builtins stuff to C in which we can reduce the
> > > size of git. Additionally, I would also like to convert scripts to
> > > builtins as an additional milestone.

Careful. It is a ton of work to get the rebase -i conversion done, and
then a ton of work to get it integrated. That will fill 3 months, very
easily.

> > > What do you think of these projects? Would it collide with Valery
> > > Tolstov's Shell to Builtins proposal?

I missed that proposal, and could only find submodule-related mails on the
public-inbox server. Care to provide a pointer?

> > Curious why all people ask about colliding with Valerys proposal here?
> > I do not think it would collide, as submodules and rebase are very
> > different areas of the code base.

Indeed ;-)

Ciao,
Johannes

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20 16:41 Ivan Tham
2017-03-20 17:41 ` Stefan Beller
2017-03-21  6:05   ` Ivan Tham
2017-03-23 17:30     ` Johannes Schindelin [this message]
2017-03-23 18:19       ` Stefan Beller
2017-03-25  2:17       ` Inaw Tham
2017-03-27 15:11         ` Johannes Schindelin
2017-03-27 16:31           ` Pickfire
2017-03-28  6:27             ` Christian Couder

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1703231827060.3767@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=pickfire@riseup.net \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox