Hi Junio & René, On Tue, 7 Feb 2017, Junio C Hamano wrote: > René Scharfe writes: > > > Swapping between different types would then still have to be done > > manually, but I wonder how common that is -- couldn't find such a case > > in our tree. > > I do not think it is a common thing to do, and more importantly, I doubt > we want to hide such a swap inside a macro. And that is why I said the > seemingly extra "type" thing may be an improvement over your original > SWAP() thing if it gives us more type safety. > > It seems that the thread has been quite for a while. Perhaps people are > happy enough with your patches? If so, let's move it forward, but I'll > wait for a while in case follow-up discussion appears soonish. The > changes are fairly well isolated and I do not think we are in a hurry. I am still unhappy about choosing to complicate things and lean heavily on the compiler to make things right again. But it appears that I am the only one with this concern, so go ahead. I promise not to say "I told you so" in case that it breaks things or that certain platforms are experiencing a disadvantage. Ciao, Johannes