From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Max Kirillov <max@max630.net>
Cc: Junio C Hamano <gitster@pobox.com>, Karsten Blees <blees@dcon.de>,
git@vger.kernel.org
Subject: Re: [PATCH] mingw: consider that UNICODE_STRING::Length counts bytes
Date: Tue, 20 Dec 2016 16:16:02 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1612201610270.54750@virtualbox> (raw)
In-Reply-To: <1482183120-21592-1-git-send-email-max@max630.net>
Hi Max,
On Mon, 19 Dec 2016, Max Kirillov wrote:
> UNICODE_STRING::Length field means size of buffer in bytes[1], despite
> of buffer itself being array of wchar_t. Because of that terminating
> zero is placed twice as far. Fix it.
This commit message needs to be wrapped at <= 76 columns per row.
> [1] https://msdn.microsoft.com/en-us/library/windows/desktop/aa380518.aspx
>
> Signed-off-by: Max Kirillov <max@max630.net>
> ---
> Access outside of buffer was very unlikely (for that user needed to redirect
> standard fd to a file with path longer than ~250 symbols), it still did not
> seem to do any harm, and otherwise it did not break because only substring is
> checked, but it was still incorrect.
Very good, thank you for fixing my mistake! I verified locally that it
does exactly the right thing with your patch.
ACK,
Dscho
next prev parent reply other threads:[~2016-12-20 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 21:32 [PATCH] mingw: consider that UNICODE_STRING::Length counts bytes Max Kirillov
2016-12-19 21:57 ` Junio C Hamano
2016-12-20 5:21 ` Max Kirillov
2016-12-20 15:16 ` Johannes Schindelin [this message]
2016-12-20 17:07 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2016-12-17 13:20 Max Kirillov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1612201610270.54750@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=blees@dcon.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=max@max630.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).