From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Pranit Bauva <pranit.bauva@gmail.com>
Subject: Re: [PATCH 0/1] Fix a long-standing isatty() problem on Windows
Date: Mon, 12 Dec 2016 10:59:01 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1612121052310.23160@virtualbox> (raw)
In-Reply-To: <xmqqmvg2nyo6.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Sun, 11 Dec 2016, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
> > I finally got a chance to debug the problems with the ever-timing-out
> > test runs of `pu` on Windows. Turns out that pb/bisect uncovered a
> > really old, really bad bug: on Windows, isatty() does not do what Git
> > expects, at least not completely: it detects interactive terminals *and
> > character devices*.
>
> Sounds as if somebody who did Windows at Microsoft had a good sense
> of humor to mimick the misnamed ENOTTY gotcha ;-)
Hehe...
> This is a great find, and a very impactful fix, as redirecting from
> /dev/null is how we try to force a "go interactive if talking to
> tty" program to realize that it is not talking to a tty.
Can we fast-track this to maint?
I will definitely ship this fix in the next Git for Windows version, but
still, it would be nice to have this in git.git as soon as possible.
Thanks,
Dscho
next prev parent reply other threads:[~2016-12-12 9:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-11 11:16 [PATCH 0/1] Fix a long-standing isatty() problem on Windows Johannes Schindelin
2016-12-11 11:16 ` [PATCH 1/1] mingw: intercept isatty() to handle /dev/null as Git expects it Johannes Schindelin
2016-12-16 17:48 ` Johannes Sixt
2016-12-16 18:08 ` Junio C Hamano
2016-12-16 18:44 ` Johannes Sixt
2016-12-16 19:05 ` Junio C Hamano
2016-12-21 17:56 ` Johannes Schindelin
2016-12-18 15:26 ` [PATCH] winansi_isatty(): fix when Git is used from CMD Johannes Sixt
2016-12-18 15:37 ` Johannes Sixt
2016-12-19 19:34 ` Johannes Sixt
2016-12-21 17:57 ` Johannes Schindelin
2016-12-20 16:53 ` Johannes Schindelin
2016-12-19 1:12 ` Junio C Hamano
2016-12-20 16:50 ` Johannes Schindelin
2016-12-20 16:59 ` Junio C Hamano
2016-12-21 17:59 ` Johannes Schindelin
2016-12-21 18:54 ` Junio C Hamano
2016-12-22 9:23 ` Johannes Schindelin
2016-12-11 17:49 ` [PATCH 0/1] Fix a long-standing isatty() problem on Windows Junio C Hamano
2016-12-12 9:59 ` Johannes Schindelin [this message]
2016-12-12 16:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1612121052310.23160@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pranit.bauva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).