From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>,
Lars Schneider <larsxschneider@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] convert: mark a file-local symbol static
Date: Mon, 17 Oct 2016 11:04:19 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610171058580.197091@virtualbox> (raw)
In-Reply-To: <20161017021825.jgpsew7qqfjrirhw@sigill.intra.peff.net>
Hi Ramsay & Peff,
On Sun, 16 Oct 2016, Jeff King wrote:
> On Mon, Oct 17, 2016 at 02:37:58AM +0100, Ramsay Jones wrote:
>
> > Hmm, well, you have to remember that 'make clean' sometimes doesn't
> > make clean. Ever since the Makefile was changed to only remove
> > $(OBJECTS), rather than *.o xdiff/*.o etc., you have to remember to
> > 'make clean' _before_ you switch branches. Otherwise, you risk leaving
> > some objects laying around. Since the script runs 'nm' on all objects
> > it finds, any stale ones can cause problems. (Of course, I almost
> > always forget, so I frequently have to manually check for and remove
> > stale objects!)
>
> Gross. I would not be opposed to a Makefile rule that outputs the
> correct set of OBJECTS so this (or other) scripts could build on it.
You could also use the method I use in Git for Windows to "extend" the
Makefile:
-- snipsnap --
cat >dummy.mak <<EOF
include Makefile
blub: $(OBJECTS)
do-something-with $^
EOF
make -f dummy.mak blub
next prev parent reply other threads:[~2016-10-17 9:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 23:46 [PATCH] convert: mark a file-local symbol static Ramsay Jones
2016-10-15 15:05 ` Lars Schneider
2016-10-15 21:01 ` Ramsay Jones
2016-10-16 0:15 ` Lars Schneider
2016-10-17 1:37 ` Ramsay Jones
2016-10-17 2:18 ` Jeff King
2016-10-17 9:04 ` Johannes Schindelin [this message]
2016-10-17 9:37 ` Jeff King
2016-10-17 17:21 ` Ramsay Jones
2016-10-17 20:07 ` Junio C Hamano
2016-10-17 20:48 ` René Scharfe
2016-10-17 20:48 ` Stefan Beller
2016-10-17 21:48 ` Ramsay Jones
2016-10-17 17:15 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610171058580.197091@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).