From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MALFORMED_FREEMAIL,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id EC6B91FD99 for ; Tue, 9 Aug 2016 11:41:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932155AbcHILlj (ORCPT ); Tue, 9 Aug 2016 07:41:39 -0400 Received: from mout.gmx.net ([212.227.17.22]:59621 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932105AbcHILli (ORCPT ); Tue, 9 Aug 2016 07:41:38 -0400 Received: from virtualbox ([37.24.141.218]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MfiFU-1bu8Zh1JCe-00NA4U; Tue, 09 Aug 2016 13:41:21 +0200 Date: Tue, 9 Aug 2016 13:41:18 +0200 (CEST) From: Johannes Schindelin X-X-Sender: virtualbox@virtualbox To: Junio C Hamano cc: Lars Schneider , Stefan Beller , Git Mailing List , Eric Sunshine , Jeff King , Johannes Sixt , Duy Nguyen , =?UTF-8?Q?Jakub_Nar=C4=99bski?= , Eric Wong Subject: Re: patch submission process, was Re: [PATCH v6 06/16] merge_recursive: abort properly upon errors In-Reply-To: Message-ID: References: <8ff71aba37be979f05abf88f467ec932aa522bdd.1470051326.git.johannes.schindelin@gmx.de> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Provags-ID: V03:K0:8e9PKxqbn3hN1CkVocGOGZrlwD/W4f4QUQ4OqGGzpoQi3Ped/95 0b1cBOmdT20MUKl7/8bw0GtFaCGefcLflrjbUy2VLpsvEG1CPCRbC2BAj/y/ywEBTSeKqaD qbaqJybXQ/Cf99pnqEVJsjVqMvThuyxEfnu/MKoGNkoFr81GpONyuCjnI1I74c8/BjgYtYA 0vTRDtocPCWorT8z/pKFA== X-UI-Out-Filterresults: notjunk:1;V01:K0:+3k47m27i1o=:o5RlrIFyi2wJhuCUsz9q63 sIqV27cMUvzO5gRnOQ9pzOomwa7CFONHQ0BeWLBjs+9JiA0DY/Z8/yhPWRqhP2W0w5ItG6H0K QFXZgtUzKYp8zVnl2MzL2wtELDrAsFdlp+c4LACvlkdcw6URcTwEZzJlAHF12cycvRZyuw0uN yWKrKDy5U5OKNk9Y6rXMMxdoZf48QD720nukXcTu8bS1kBbxHXBta5q5Phc3f2fsn2lYOOjY1 EfsUYDS7Ma5PB+Q5LbSAkejrB4anijnuYqtGWaYLHBoRNW7ky1o5DPbkoBMdew5p7lKd5P9R/ lIQZk+QAonecHPnCU3W/JLKqCc9ZBZmFx9GszgZ2eivXATV9K7MAm9m4p06sXr3zO955jKAyQ Az406YjFxEQy8geJXMIgOqbQHiYtKmfwj+yunVIYGIXe2Fn7Vvct7W72J4fGgA8xnCqiEItSo mTdAJ0JbtbkNwLMrWNrqlO+qj3c3blJQQjUE6NlQ+y7mkGoMOAqKRDRKVqeBMfy9R2gscIAh5 YABS4mpsHeM3zREKDalmVe/Mm3VNP8kkhGeQkek9RT29PgzV9xvh6hknwIOK218y3PdZ2zKg3 DKcDRYV5W4bJ9s9rh9Mc45h9BZ+S5Neq/b8X05hoWaruB0MlLSpRfuLQH04vahLUjK/qdoQ4i UDHkVgI3SLyV7fn+AEJRjKjGwVzJzQsbpEy4J97qkAwk8LKGKHmTnPLWKiCFE27PeUT1IDAAW abN+7zTJNsv1+3HRRtJUxhC0rvuzODucTxx612gH/bK5+DPoevKkjoAiMJ+sDdT7njXcZp/gA vdZ/qMn Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Junio, On Mon, 8 Aug 2016, Junio C Hamano wrote: > Lars Schneider writes: > > > 4.) Reviewing patches is super hard for me because my email client > > does not support patch color highlighting and I can't easily expand > > context or look at the history of code touched by the patch (e.g via > > git blame). I tried to setup Alpine but I wasn't happy with the > > interface either. I like patches with a GitHub URL for review but then > > I need to find the right line in the original email to write a > > comment. > > Unless a patch is about an area you are super familiar with so that you > know what is beyond the context of the patch to be able to judge if the > change is good in the context of the file being touched, it is always > hard to review from inside a mail reader. > > Running "git am" is a good first step to review such a patch, as that > lets you view the resulting code with the full power of Git. As you > gain experience on the codebase, you'll be able to spot more problems > while in your mail reader. I am glad that you agree that the requirement to manually transform the patches back into Git (where they had been originally to begin with) is cumbersome. This is the first time that I see you admit it ;-) Ciao, Dscho