From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Kevin Willford <kcwillford@gmail.com>, git@vger.kernel.org
Subject: Re: [[PATCH v2] 0/4] Use header data patch ids for rebase to avoid loading file content
Date: Mon, 1 Aug 2016 11:01:01 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1608011059040.149069@virtualbox> (raw)
In-Reply-To: <xmqqshusmby9.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Fri, 29 Jul 2016, Junio C Hamano wrote:
> Kevin Willford <kcwillford@gmail.com> writes:
>
> > This patch series is to remove the hand rolled hashmap in the patch_ids
> > and use the hashmap.h implementation. It also introduces the idea of having
> > a header only patch id so that the contents of the files do not have to be
> > loaded in order to determine if two commits are different.
>
> > Subject: Re: [[PATCH v2] 0/4] Use header data patch ids for rebase to avoid loading file content
>
> Did you do "format-patch --subject-prefix='[PATCH v2]'" or something
> like that?
This is my fault, sorry, I suggested this usage (misremembering the
semantics because I only use my mail-patch-series.sh helper and never use
format-patch manually anymore).
> git format-patch --subject-prefix='PATCH v2'
>
> or even better
>
> git format-patch -v2
>
> would have been more appropriate.
Oooh, I did not know about the latter form. Nice.
Thanks,
Dscho
prev parent reply other threads:[~2016-08-01 9:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 16:19 [[PATCH v2] 0/4] Use header data patch ids for rebase to avoid loading file content Kevin Willford
2016-07-29 16:19 ` [[PATCH v2] 1/4] patch-ids: stop using a hand-rolled hashmap implementation Kevin Willford
2016-07-29 20:47 ` Junio C Hamano
2016-08-01 8:54 ` Johannes Schindelin
2016-08-01 20:04 ` Junio C Hamano
2016-08-01 22:34 ` Eric Wong
2016-08-02 10:30 ` Johannes Schindelin
2016-08-02 17:01 ` Junio C Hamano
2016-08-02 18:04 ` Junio C Hamano
2016-07-29 21:29 ` Junio C Hamano
2016-07-29 16:19 ` [[PATCH v2] 2/4] patch-ids: replace the seen indicator with a commit pointer Kevin Willford
2016-07-29 21:03 ` Junio C Hamano
2016-07-29 16:19 ` [[PATCH v2] 3/4] patch-ids: add flag to create the diff patch id using header only data Kevin Willford
2016-07-29 16:19 ` [[PATCH v2] 4/4] rebase: avoid computing unnecessary patch IDs Kevin Willford
2016-07-29 21:46 ` Junio C Hamano
2016-08-01 8:58 ` Johannes Schindelin
2016-08-01 20:11 ` Junio C Hamano
2016-08-02 9:50 ` Jakub Narębski
2016-08-02 17:06 ` Junio C Hamano
2016-08-02 10:45 ` Johannes Schindelin
2016-08-02 17:08 ` Junio C Hamano
2016-08-04 3:00 ` Junio C Hamano
2016-08-04 14:21 ` Johannes Schindelin
2016-07-29 20:22 ` [[PATCH v2] 0/4] Use header data patch ids for rebase to avoid loading file content Junio C Hamano
2016-08-01 9:01 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1608011059040.149069@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kcwillford@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).