From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.9 required=3.0 tests=AWL,BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 21D59203C1 for ; Mon, 25 Jul 2016 07:06:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbcGYHFw (ORCPT ); Mon, 25 Jul 2016 03:05:52 -0400 Received: from mout.gmx.net ([212.227.17.20]:55197 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353AbcGYHFi (ORCPT ); Mon, 25 Jul 2016 03:05:38 -0400 Received: from virtualbox ([37.24.142.100]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0M4o41-1b6Jhg2k4z-00z1Yi; Mon, 25 Jul 2016 09:05:33 +0200 Date: Mon, 25 Jul 2016 09:04:49 +0200 (CEST) From: Johannes Schindelin X-X-Sender: virtualbox@virtualbox To: Jon Forrest cc: =?UTF-8?Q?Jakub_Nar=C4=99bski?= , git Subject: Re: [ANN] Pro Git Reedited 2nd Edition In-Reply-To: <89e0a631-6396-e56e-0c1d-37acdbf8eda4@gmail.com> Message-ID: References: <579483B7.4090508@gmail.com> <6f7eea6b-2446-5740-cbec-141d71a33ea1@gmail.com> <5795087C.4010503@gmail.com> <89e0a631-6396-e56e-0c1d-37acdbf8eda4@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1356478984-1469430290=:14111" X-Provags-ID: V03:K0:/BfgFgwZSs1VlTJ2uhJhN99TJCPvfY5lyaUsKKR01671xW0NAVv KpsCbprq5FV83ntewzsh1eLnIq1hNHsZFP8st41asSsjOIx4DcWS2PhoNS5XY7MsntY/tAe GQ8YXp+XszL3ySo/XLkk9rmlhG8yLVhzDeFrKAwhx8/9Qps83hc54WFxIcFIuUSWeIl9uPx cc+Zzb5H3LwzvRvvpInXQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:9tHeNB7tXSk=:jyb/hKNaoecmg3Cx1WmIwk 7vkyVQ8FywyLUKJeb+JFXKCUE8Y03ihy5oo6+wHJfsjATJB9dLP246ris25De+u/fb2NDaHM5 resDe4ec0AjBqb5jLxJm+GxCLSKE8XxY8M2+p+fCeJD5tp5VGX0eKSiMSwhV0IPX32IeIT+AR BH4l8qv081fRlE75sc4Smq8YwNArDEkSYar/3PDzMT/Bd06VXUbIeFKSsA6MB/64MBg0iAUYH +9scv2YrhbP+SeiQkEVJUrx4J/aqI/MCitC6L3NXVUKAfHVpu+nwRhj/o946fIjOvZJvcE58B LJ8RAiiSHLgTuYFvUCKFI5kWlQ/nQPFsExA+XzF7SLD77o8Vli8v4x/mCwvqCwRAJLpR3Ewc0 oDd+06GokhPUtbutB/9OGz5HpoHnrRrwYOPVoMs9S+bBzsSzyGQFGsFUN8mIFFTMlWPKO64Vv bp5UK/zrSS5N79x4SGqA0VlLIwGMi7munOuPgFOLm+Ih5wYvQ1MkepEc0CLh1jkoRm2cq2SvT /JWA/R8/CdaBiHWixOYUNzkNNKsT6vvutAnlDRp11gJo+A9rjkZEYOaM2k2Td6Us1Rvi16o/Z k+xClHGpv2hfNhdg9bmN2EhodBPxQ5zv5HkOo+YfwpHTchWA0hkWReBw6JMYq+l1HEkd/hrxE tvx4CVQ9EuFGDj/nkAvcVm2KpV3aWmbYO4+Orec7PxSddOERngC8s4ca5aqtiF49ShQg97Qzu fSaas6Uqm33nzbzkzTooTlj8A6ngjNc+Olot5/mU7lGDgEzEDGDLe7LSDlv030jXhDLC6OAMb N/tytsv Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1356478984-1469430290=:14111 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Hi Jon, On Sun, 24 Jul 2016, Jon Forrest wrote: > On 7/24/2016 11:27 AM, Jakub Nar=C4=99bski wrote: >=20 > > All right. One issue I have after browsing through changes is that > > description of changes and their granularity is severely lacking. "A > > few more very minor changes.", "More piddly changes.", "should have > > included this in last commit" are not good commit messages. >=20 > You're absolutely right. I probably should have squashed those commits. > Those comments aren't really intended for public consumption. > Since I made many changes per commit, I really couldn't give an > instructive commit message. >=20 > Now that this edition is done, I plan on following good commit > practices in the future. For the record: I found it a good practice to clean up my commits (read: reword commit messages, split/join commits) *even after* pushing them to a public repository. Interactive rebase to the rescue. That practice is not solely for others' benefit, by the way. You will most likely find that it not only structures your work better, you will also find that it turns up things that were forgotten and still need to be addressed. Ciao, Johannes --8323329-1356478984-1469430290=:14111--