git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jon Forrest <nobozo@gmail.com>
Cc: "Jakub Narębski" <jnareb@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [ANN] Pro Git Reedited 2nd Edition
Date: Mon, 25 Jul 2016 09:04:49 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1607250900260.14111@virtualbox> (raw)
In-Reply-To: <89e0a631-6396-e56e-0c1d-37acdbf8eda4@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

Hi Jon,

On Sun, 24 Jul 2016, Jon Forrest wrote:

> On 7/24/2016 11:27 AM, Jakub Narębski wrote:
> 
> > All right. One issue I have after browsing through changes is that
> > description of changes and their granularity is severely lacking.  "A
> > few more very minor changes.", "More piddly changes.", "should have
> > included this in last commit" are not good commit messages.
> 
> You're absolutely right. I probably should have squashed those commits.
> Those comments aren't really intended for public consumption.
> Since I made many changes per commit, I really couldn't give an
> instructive commit message.
> 
> Now that this edition is done, I plan on following good commit
> practices in the future.

For the record: I found it a good practice to clean up my commits (read:
reword commit messages, split/join commits) *even after* pushing them to a
public repository.

Interactive rebase to the rescue.

That practice is not solely for others' benefit, by the way.

You will most likely find that it not only structures your work better,
you will also find that it turns up things that were forgotten and still
need to be addressed.

Ciao,
Johannes

  reply	other threads:[~2016-07-25  7:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-24  4:07 [ANN] Pro Git Reedited 2nd Edition Jon Forrest
2016-07-24  9:00 ` Jakub Narębski
     [not found]   ` <6f7eea6b-2446-5740-cbec-141d71a33ea1@gmail.com>
2016-07-24 17:19     ` Jakub Narębski
2016-07-24 17:34       ` Jon Forrest
2016-07-24 18:27         ` Jakub Narębski
2016-07-24 18:41           ` Jon Forrest
2016-07-25  7:04             ` Johannes Schindelin [this message]
2016-07-24 20:03           ` Jon Forrest
2016-07-26  9:15 ` Manlio Perillo
2016-07-26 14:22   ` Jon Forrest
2016-08-12 13:11 ` Sitaram Chamarty
2016-08-12 14:37   ` Jon Forrest
2016-08-13  0:30     ` Sitaram Chamarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1607250900260.14111@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=nobozo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).