From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Eric Wong <e@80x24.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] config.mak.uname: set PERL_PATH for FreeBSD 5.0+
Date: Thu, 21 Jul 2016 17:17:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1607211716100.14111@virtualbox> (raw)
In-Reply-To: <20160720180702.GA13404@starla>
Hi Eric,
On Wed, 20 Jul 2016, Eric Wong wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> >
> > On Wed, 20 Jul 2016, Eric Wong wrote:
> >
> > > diff --git a/config.mak.uname b/config.mak.uname
> > > index a88f139..6c29545 100644
> > > --- a/config.mak.uname
> > > +++ b/config.mak.uname
> > > @@ -202,6 +202,11 @@ ifeq ($(uname_S),FreeBSD)
> > > NO_UINTMAX_T = YesPlease
> > > NO_STRTOUMAX = YesPlease
> > > endif
> > > + R_MAJOR := $(shell expr "$(uname_R)" : '\([0-9]*\)\.')
> > > +
> > > + ifeq ($(shell test "$(R_MAJOR)" -ge 5 && echo 1),1)
> > > + PERL_PATH = /usr/local/bin/perl
> > > + endif
> >
> > In keeping with other uname_R usage, should this not read
> >
> > # Since FreeBSD 5.0, Perl is part of the core
> > ifneq ($(shell expr "$(uname_R)" : '[1-4]\.'),2)
> > PERL_PATH = /usr/local/bin/perl
> > endif
> >
> > instead?
>
> That's fine; however I don't use `expr` often, so it required
> a little more time to realize the '2' means 2 characters were
> matched.
I never use `expr`, so I had to go and see the surrounding code to
determine what the code style is.
> Also, my use of a numeric comparison may be more future-proof
> in case FreeBSD decides to have /usr/bin/perl again.
That is a very theoretical concern ;-)
Ciao,
Dscho
prev parent reply other threads:[~2016-07-21 15:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 2:56 [PATCH] config.mak.uname: set PERL_PATH for FreeBSD 5.0+ Eric Wong
2016-07-20 11:25 ` Johannes Schindelin
2016-07-20 18:07 ` Eric Wong
2016-07-20 18:10 ` Junio C Hamano
2016-07-21 1:02 ` brian m. carlson
2016-07-21 15:17 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607211716100.14111@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).