From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Sven Strickroth <email@cs-ware.de>
Subject: Re: [PATCH 2/3] mmap(win32): avoid copy-on-write when it is unnecessary
Date: Thu, 28 Apr 2016 10:03:23 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1604281001220.2896@virtualbox> (raw)
In-Reply-To: <57210A38.4080203@kdbg.org>
Hi Hannes,
On Wed, 27 Apr 2016, Johannes Sixt wrote:
> Am 27.04.2016 um 08:43 schrieb Johannes Schindelin:
> > On Tue, 26 Apr 2016, Johannes Sixt wrote:
> > > Should we insert a check for MAP_PRIVATE to catch
> > > unexpected use-cases (think of the index-helper daemon effort)?
> >
> > I agree, we should have such a check. The line above the `die("Invalid
> > usage ...")` that you can read as first line in above-quoted hunk reads:
> >
> > if (!(flags & MAP_PRIVATE))
> >
> > So I think we're fine :-)
>
> Oh, well... I thought I had checked the code before I wrote my question, but
> it seems I was blind... ;)
Don't worry! I really appreciate your review!
Ciao,
Johannes
next prev parent reply other threads:[~2016-04-28 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 14:31 [PATCH 0/3] Improve the mmap() emulation on Windows Johannes Schindelin
2016-04-22 14:31 ` [PATCH 1/3] win32mmap: set errno appropriately Johannes Schindelin
2016-04-22 14:31 ` [PATCH 2/3] mmap(win32): avoid copy-on-write when it is unnecessary Johannes Schindelin
2016-04-26 18:53 ` Johannes Sixt
2016-04-27 6:43 ` Johannes Schindelin
2016-04-27 18:51 ` Johannes Sixt
2016-04-28 8:03 ` Johannes Schindelin [this message]
2016-04-22 14:31 ` [PATCH 3/3] mmap(win32): avoid expensive fstat() call Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1604281001220.2896@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=email@cs-ware.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).