From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Cameron Currie <me@cameroncurrie.net>
Cc: Daurnimator <quae@daurnimator.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-stash: Don't GPG sign when stashing changes
Date: Thu, 14 Apr 2016 17:50:57 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1604141748370.2967@virtualbox> (raw)
In-Reply-To: <CAOAY-+1TztY95z3Yi34HB3aYUG5aOHKK9G3OmpYM41ugDMtJUA@mail.gmail.com>
Hi Cameron,
On Wed, 13 Apr 2016, Cameron Currie wrote:
> > > On Thu, 7 Apr 2016, daurnimator wrote:
> > >
> > >> Cameron Currie <me <at> cameroncurrie.net> writes:
> > >> > This is helpful for folks with commit.gpgsign = true in their
> > >> > .gitconfig.
> > >>
> > >> > https://github.com/git/git/pull/186
> > >>
> > >> I too would like this.
> > >> Bumping due to lack of attention.
> > >
> > > It lacks a Sign-off, our convention is to continue in lower-case
> > > after the colon in the commit's subject, and I think that it would
> > > be good to write so much as one paragraph in the commit message.
>
> I don't think I can find the time right now. Feel free to rewrite the
> commit message to match convention.
I am afraid that it would be improper for anybody to add your Sign-off, as
it is *your* statement that you are indeed contributing this as Open
Source, and that you indeed are free to do so.
If you do not find the time to take care of these small changes, I fear
the Git maintainer will *have* to drop your patch to avoid hassle for
himself.
Ciao,
Johannes
next prev parent reply other threads:[~2016-04-14 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 17:32 [PATCH] git-stash: Don't GPG sign when stashing changes Cameron Currie
2015-11-06 18:56 ` Junio C Hamano
2016-04-07 2:24 ` daurnimator
2016-04-07 8:19 ` Johannes Schindelin
2016-04-12 2:46 ` Daurnimator
[not found] ` <CAOAY-+1TztY95z3Yi34HB3aYUG5aOHKK9G3OmpYM41ugDMtJUA@mail.gmail.com>
2016-04-14 15:50 ` Johannes Schindelin [this message]
2016-05-02 6:06 ` Daurnimator
2016-05-02 20:50 ` [PATCH v2] " Cameron Currie
2016-05-02 21:57 ` Junio C Hamano
2016-05-02 23:56 ` Daurnimator
2016-05-03 1:21 ` Junio C Hamano
2016-05-06 6:06 ` Daurnimator
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1604141748370.2967@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=me@cameroncurrie.net \
--cc=quae@daurnimator.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).