* [PATCH] Mark win32's pthread_exit() as NORETURN
@ 2016-03-01 13:53 Johannes Schindelin
2016-03-01 13:57 ` Jeff King
2016-03-01 14:13 ` [PATCH v2] " Johannes Schindelin
0 siblings, 2 replies; 12+ messages in thread
From: Johannes Schindelin @ 2016-03-01 13:53 UTC (permalink / raw
To: Junio C Hamano; +Cc: git, Jeff King, Torsten Bögershausen
The pthread_exit() function is not expected to return. Ever.
Pointed out by Jeff King.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
compat/win32/pthread.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
index 20b35a2..148db60 100644
--- a/compat/win32/pthread.h
+++ b/compat/win32/pthread.h
@@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
#define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
extern pthread_t pthread_self(void);
-static inline int pthread_exit(void *ret)
+static inline int NORETURN pthread_exit(void *ret)
{
ExitThread((DWORD)(intptr_t)ret);
}
--
2.7.2.windows.1.5.g64acc33
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] Mark win32's pthread_exit() as NORETURN
2016-03-01 13:53 [PATCH] Mark win32's pthread_exit() as NORETURN Johannes Schindelin
@ 2016-03-01 13:57 ` Jeff King
2016-03-01 14:11 ` Johannes Schindelin
2016-03-01 14:13 ` [PATCH v2] " Johannes Schindelin
1 sibling, 1 reply; 12+ messages in thread
From: Jeff King @ 2016-03-01 13:57 UTC (permalink / raw
To: Johannes Schindelin; +Cc: Junio C Hamano, git, Torsten Bögershausen
On Tue, Mar 01, 2016 at 02:53:04PM +0100, Johannes Schindelin wrote:
> The pthread_exit() function is not expected to return. Ever.
>
> Pointed out by Jeff King.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> compat/win32/pthread.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
> index 20b35a2..148db60 100644
> --- a/compat/win32/pthread.h
> +++ b/compat/win32/pthread.h
> @@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
> #define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
> extern pthread_t pthread_self(void);
>
> -static inline int pthread_exit(void *ret)
> +static inline int NORETURN pthread_exit(void *ret)
> {
> ExitThread((DWORD)(intptr_t)ret);
> }
Looks obviously correct to me (I'll assume Windows isn't so crazy as to
let ExitThread ever return :) ).
-Peff
> --
> 2.7.2.windows.1.5.g64acc33
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Mark win32's pthread_exit() as NORETURN
2016-03-01 13:57 ` Jeff King
@ 2016-03-01 14:11 ` Johannes Schindelin
0 siblings, 0 replies; 12+ messages in thread
From: Johannes Schindelin @ 2016-03-01 14:11 UTC (permalink / raw
To: Jeff King; +Cc: Junio C Hamano, git, Torsten Bögershausen
Hi Peff,
On Tue, 1 Mar 2016, Jeff King wrote:
> On Tue, Mar 01, 2016 at 02:53:04PM +0100, Johannes Schindelin wrote:
>
> > The pthread_exit() function is not expected to return. Ever.
> >
> > Pointed out by Jeff King.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > compat/win32/pthread.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
> > index 20b35a2..148db60 100644
> > --- a/compat/win32/pthread.h
> > +++ b/compat/win32/pthread.h
> > @@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
> > #define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
> > extern pthread_t pthread_self(void);
> >
> > -static inline int pthread_exit(void *ret)
> > +static inline int NORETURN pthread_exit(void *ret)
> > {
> > ExitThread((DWORD)(intptr_t)ret);
> > }
>
> Looks obviously correct to me (I'll assume Windows isn't so crazy as to
> let ExitThread ever return :) ).
Indeed, you are correct in your implicit assumption that I should have
clarified that in my commit message. I will amend the commit message.
Ciao,
Dscho
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] Mark win32's pthread_exit() as NORETURN
2016-03-01 13:53 [PATCH] Mark win32's pthread_exit() as NORETURN Johannes Schindelin
2016-03-01 13:57 ` Jeff King
@ 2016-03-01 14:13 ` Johannes Schindelin
2016-03-01 14:38 ` stefan.naewe
` (2 more replies)
1 sibling, 3 replies; 12+ messages in thread
From: Johannes Schindelin @ 2016-03-01 14:13 UTC (permalink / raw
To: Junio C Hamano; +Cc: git, Jeff King, Torsten Bögershausen
The pthread_exit() function is not expected to return. Ever. On Windows,
we call ExitThread() whose documentation claims: "This function does not
return a value.":
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659
Pointed out by Jeff King.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
Relative to v1, only the commit message changed (to clarify that
ExitThread() indeed never returns).
compat/win32/pthread.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
index 20b35a2..148db60 100644
--- a/compat/win32/pthread.h
+++ b/compat/win32/pthread.h
@@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
#define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
extern pthread_t pthread_self(void);
-static inline int pthread_exit(void *ret)
+static inline int NORETURN pthread_exit(void *ret)
{
ExitThread((DWORD)(intptr_t)ret);
}
--
2.7.2.windows.1.5.g64acc33
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2] Mark win32's pthread_exit() as NORETURN
2016-03-01 14:13 ` [PATCH v2] " Johannes Schindelin
@ 2016-03-01 14:38 ` stefan.naewe
2016-03-01 17:57 ` Junio C Hamano
2016-03-02 19:11 ` Johannes Schindelin
2016-03-01 19:34 ` Johannes Sixt
2016-03-02 19:11 ` [PATCH v3] " Johannes Schindelin
2 siblings, 2 replies; 12+ messages in thread
From: stefan.naewe @ 2016-03-01 14:38 UTC (permalink / raw
To: johannes.schindelin, gitster; +Cc: git, peff, tboegi
Am 01.03.2016 um 15:13 schrieb Johannes Schindelin:
> The pthread_exit() function is not expected to return. Ever. On Windows,
> we call ExitThread() whose documentation claims: "This function does not
> return a value.":
Does this really mean that ExitThread() does not return ?
Just wondering...
> https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659
>
> Pointed out by Jeff King.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>
> Relative to v1, only the commit message changed (to clarify that
> ExitThread() indeed never returns).
>
> compat/win32/pthread.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
> index 20b35a2..148db60 100644
> --- a/compat/win32/pthread.h
> +++ b/compat/win32/pthread.h
> @@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
> #define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
> extern pthread_t pthread_self(void);
>
> -static inline int pthread_exit(void *ret)
> +static inline int NORETURN pthread_exit(void *ret)
> {
> ExitThread((DWORD)(intptr_t)ret);
> }
> --
Stefan
--
----------------------------------------------------------------
/dev/random says: We're lost, but we're making good time.
python -c "print '73746566616e2e6e616577654061746c61732d656c656b74726f6e696b2e636f6d'.decode('hex')"
GPG Key fingerprint = 2DF5 E01B 09C3 7501 BCA9 9666 829B 49C5 9221 27AF
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] Mark win32's pthread_exit() as NORETURN
2016-03-01 14:38 ` stefan.naewe
@ 2016-03-01 17:57 ` Junio C Hamano
2016-03-02 19:11 ` Johannes Schindelin
1 sibling, 0 replies; 12+ messages in thread
From: Junio C Hamano @ 2016-03-01 17:57 UTC (permalink / raw
To: johannes.schindelin; +Cc: stefan.naewe, git, peff, tboegi
<stefan.naewe@atlas-elektronik.com> writes:
> Am 01.03.2016 um 15:13 schrieb Johannes Schindelin:
>> The pthread_exit() function is not expected to return. Ever. On Windows,
>> we call ExitThread() whose documentation claims: "This function does not
>> return a value.":
>
> Does this really mean that ExitThread() does not return ?
>
> Just wondering...
;-).
That made me re-read the patch and notice another thing... Dscho, I
think you would need s/int/void/, too, no?
>
>> https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659
>>
>> Pointed out by Jeff King.
>>
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>> ---
>>
>> Relative to v1, only the commit message changed (to clarify that
>> ExitThread() indeed never returns).
>>
>> compat/win32/pthread.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
>> index 20b35a2..148db60 100644
>> --- a/compat/win32/pthread.h
>> +++ b/compat/win32/pthread.h
>> @@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
>> #define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
>> extern pthread_t pthread_self(void);
>>
>> -static inline int pthread_exit(void *ret)
>> +static inline int NORETURN pthread_exit(void *ret)
>> {
>> ExitThread((DWORD)(intptr_t)ret);
>> }
>> --
>
>
> Stefan
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] Mark win32's pthread_exit() as NORETURN
2016-03-01 14:13 ` [PATCH v2] " Johannes Schindelin
2016-03-01 14:38 ` stefan.naewe
@ 2016-03-01 19:34 ` Johannes Sixt
2016-03-01 19:44 ` Junio C Hamano
2016-03-02 19:11 ` [PATCH v3] " Johannes Schindelin
2 siblings, 1 reply; 12+ messages in thread
From: Johannes Sixt @ 2016-03-01 19:34 UTC (permalink / raw
To: Johannes Schindelin, Junio C Hamano
Cc: git, Jeff King, Torsten Bögershausen
Am 01.03.2016 um 15:13 schrieb Johannes Schindelin:
> The pthread_exit() function is not expected to return. Ever. On Windows,
> we call ExitThread() whose documentation claims: "This function does not
> return a value.":
>
> https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659
This is misleading: MSDN marks all functions declared void as "does not
return a value," for example, look at EnterCriticalSection:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682608
For this reason, I actually prefer your version 1 patch without the
explanation.
>
> Pointed out by Jeff King.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>
> Relative to v1, only the commit message changed (to clarify that
> ExitThread() indeed never returns).
>
> compat/win32/pthread.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
> index 20b35a2..148db60 100644
> --- a/compat/win32/pthread.h
> +++ b/compat/win32/pthread.h
> @@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
> #define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
> extern pthread_t pthread_self(void);
>
> -static inline int pthread_exit(void *ret)
> +static inline int NORETURN pthread_exit(void *ret)
I would have written it as
#ifdef __GNUC__
__attribute__((__noreturn__))
#endif
static inline int pthread_exit(void *ret) ...
but I can live with your version as long as it compiles.
Your solution is pragmatic: NORETURN is defined in git-compat-util.h,
and by using it here, we depend on that pthread.h is included
sufficiently late that the macro is available at this point. The
instance in compat/nedmalloc/malloc.c.h is bracketed with #ifndef WIN32
so that it is not compiled on Windows, all other instances are after
git-compat-util.h or cache.h or in headers that are to be included only
after git-compat-util.h or cache.h per convention. Looks like we are safe.
> {
> ExitThread((DWORD)(intptr_t)ret);
> }
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] Mark win32's pthread_exit() as NORETURN
2016-03-01 19:34 ` Johannes Sixt
@ 2016-03-01 19:44 ` Junio C Hamano
2016-03-02 19:10 ` Johannes Schindelin
0 siblings, 1 reply; 12+ messages in thread
From: Junio C Hamano @ 2016-03-01 19:44 UTC (permalink / raw
To: Johannes Sixt
Cc: Johannes Schindelin, git, Jeff King, Torsten Bögershausen
Johannes Sixt <j6t@kdbg.org> writes:
> Am 01.03.2016 um 15:13 schrieb Johannes Schindelin:
>> The pthread_exit() function is not expected to return. Ever. On Windows,
>> we call ExitThread() whose documentation claims: "This function does not
>> return a value.":
>>
>> https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659
>
> This is misleading: MSDN marks all functions declared void as "does
> not return a value," for example, look at EnterCriticalSection:
>
> https://msdn.microsoft.com/en-us/library/windows/desktop/ms682608
>
> For this reason, I actually prefer your version 1 patch without the
> explanation.
;-)
>> -static inline int pthread_exit(void *ret)
>> +static inline int NORETURN pthread_exit(void *ret)
>
> I would have written it as
>
> #ifdef __GNUC__
> __attribute__((__noreturn__))
> #endif
> static inline int pthread_exit(void *ret) ...
>
> but I can live with your version as long as it compiles.
Either way, let's make sure that the final version returns "void",
cf.
http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_exit.html
Thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] Mark win32's pthread_exit() as NORETURN
2016-03-01 19:44 ` Junio C Hamano
@ 2016-03-02 19:10 ` Johannes Schindelin
0 siblings, 0 replies; 12+ messages in thread
From: Johannes Schindelin @ 2016-03-02 19:10 UTC (permalink / raw
To: Junio C Hamano; +Cc: Johannes Sixt, git, Jeff King, Torsten Bögershausen
Hi,
On Tue, 1 Mar 2016, Junio C Hamano wrote:
> Johannes Sixt <j6t@kdbg.org> writes:
>
> > Am 01.03.2016 um 15:13 schrieb Johannes Schindelin:
> >> The pthread_exit() function is not expected to return. Ever. On Windows,
> >> we call ExitThread() whose documentation claims: "This function does not
> >> return a value.":
> >>
> >> https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659
> >
> > This is misleading: MSDN marks all functions declared void as "does
> > not return a value," for example, look at EnterCriticalSection:
> >
> > https://msdn.microsoft.com/en-us/library/windows/desktop/ms682608
> >
> > For this reason, I actually prefer your version 1 patch without the
> > explanation.
>
> ;-)
Well, I really like to have that link so I can find it very easily myself
by simply inspecting the Git log. And the explanation itself was easily
fixed.
>
> >> -static inline int pthread_exit(void *ret)
> >> +static inline int NORETURN pthread_exit(void *ret)
> >
> > I would have written it as
> >
> > #ifdef __GNUC__
> > __attribute__((__noreturn__))
> > #endif
> > static inline int pthread_exit(void *ret) ...
> >
> > but I can live with your version as long as it compiles.
>
> Either way, let's make sure that the final version returns "void",
> cf.
>
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_exit.html
Fixed, too, in the upcoming v3.
Ciao,
Dscho
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] Mark win32's pthread_exit() as NORETURN
2016-03-01 14:38 ` stefan.naewe
2016-03-01 17:57 ` Junio C Hamano
@ 2016-03-02 19:11 ` Johannes Schindelin
1 sibling, 0 replies; 12+ messages in thread
From: Johannes Schindelin @ 2016-03-02 19:11 UTC (permalink / raw
To: stefan.naewe; +Cc: gitster, git, peff, tboegi
Hi,
On Tue, 1 Mar 2016, stefan.naewe@atlas-elektronik.com wrote:
> Am 01.03.2016 um 15:13 schrieb Johannes Schindelin:
> > The pthread_exit() function is not expected to return. Ever. On Windows,
> > we call ExitThread() whose documentation claims: "This function does not
> > return a value.":
>
> Does this really mean that ExitThread() does not return ?
I fixed the commit message in v3.
Thanks,
Dscho
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3] Mark win32's pthread_exit() as NORETURN
2016-03-01 14:13 ` [PATCH v2] " Johannes Schindelin
2016-03-01 14:38 ` stefan.naewe
2016-03-01 19:34 ` Johannes Sixt
@ 2016-03-02 19:11 ` Johannes Schindelin
2016-03-02 20:33 ` Junio C Hamano
2 siblings, 1 reply; 12+ messages in thread
From: Johannes Schindelin @ 2016-03-02 19:11 UTC (permalink / raw
To: Junio C Hamano; +Cc: git, Jeff King, Torsten Bögershausen
The pthread_exit() function is not expected to return. Ever. On Windows,
we call ExitThread() whose documentation claims: "Ends the calling
thread", i.e. there is no condition in which this function simply
returns: https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659
While at it, fix the return type to be void, as per
http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_exit.html
Pointed out by Jeff King, helped by Stefan Naewe, Junio Hamano &
Johannes Sixt.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
compat/win32/pthread.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Interdiff vs v2:
diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
index 148db60..b6ed9e7 100644
--- a/compat/win32/pthread.h
+++ b/compat/win32/pthread.h
@@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
#define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
extern pthread_t pthread_self(void);
-static inline int NORETURN pthread_exit(void *ret)
+static inline void NORETURN pthread_exit(void *ret)
{
ExitThread((DWORD)(intptr_t)ret);
}
diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
index 20b35a2..b6ed9e7 100644
--- a/compat/win32/pthread.h
+++ b/compat/win32/pthread.h
@@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
#define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
extern pthread_t pthread_self(void);
-static inline int pthread_exit(void *ret)
+static inline void NORETURN pthread_exit(void *ret)
{
ExitThread((DWORD)(intptr_t)ret);
}
--
2.7.2.windows.1.5.g64acc33
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3] Mark win32's pthread_exit() as NORETURN
2016-03-02 19:11 ` [PATCH v3] " Johannes Schindelin
@ 2016-03-02 20:33 ` Junio C Hamano
0 siblings, 0 replies; 12+ messages in thread
From: Junio C Hamano @ 2016-03-02 20:33 UTC (permalink / raw
To: Johannes Schindelin; +Cc: git, Jeff King, Torsten Bögershausen
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> The pthread_exit() function is not expected to return. Ever. On Windows,
> we call ExitThread() whose documentation claims: "Ends the calling
> thread", i.e. there is no condition in which this function simply
> returns: https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659
>
> While at it, fix the return type to be void, as per
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_exit.html
>
> Pointed out by Jeff King, helped by Stefan Naewe, Junio Hamano &
> Johannes Sixt.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
Thanks, will queue.
> compat/win32/pthread.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> Interdiff vs v2:
>
> diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
> index 148db60..b6ed9e7 100644
> --- a/compat/win32/pthread.h
> +++ b/compat/win32/pthread.h
> @@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
> #define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
> extern pthread_t pthread_self(void);
>
> -static inline int NORETURN pthread_exit(void *ret)
> +static inline void NORETURN pthread_exit(void *ret)
> {
> ExitThread((DWORD)(intptr_t)ret);
> }
>
>
> diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
> index 20b35a2..b6ed9e7 100644
> --- a/compat/win32/pthread.h
> +++ b/compat/win32/pthread.h
> @@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr);
> #define pthread_equal(t1, t2) ((t1).tid == (t2).tid)
> extern pthread_t pthread_self(void);
>
> -static inline int pthread_exit(void *ret)
> +static inline void NORETURN pthread_exit(void *ret)
> {
> ExitThread((DWORD)(intptr_t)ret);
> }
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-03-02 20:33 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-01 13:53 [PATCH] Mark win32's pthread_exit() as NORETURN Johannes Schindelin
2016-03-01 13:57 ` Jeff King
2016-03-01 14:11 ` Johannes Schindelin
2016-03-01 14:13 ` [PATCH v2] " Johannes Schindelin
2016-03-01 14:38 ` stefan.naewe
2016-03-01 17:57 ` Junio C Hamano
2016-03-02 19:11 ` Johannes Schindelin
2016-03-01 19:34 ` Johannes Sixt
2016-03-01 19:44 ` Junio C Hamano
2016-03-02 19:10 ` Johannes Schindelin
2016-03-02 19:11 ` [PATCH v3] " Johannes Schindelin
2016-03-02 20:33 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).