mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Alex Vandiver <>
To: Junio C Hamano <>
	Johannes Schindelin <>,
	Ben Peart <>
Subject: Re: [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path
Date: Wed, 20 Dec 2017 12:59:31 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1712201108190.10810@alexmv-linux> (raw)
In-Reply-To: <>

On Tue, 19 Dec 2017, Junio C Hamano wrote:
> Alex Vandiver <> writes:
> > Subject: Re: [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path
> Perhaps
> "Subject: fsmonitor.h: include dir.h"

Certainly more concise.

> But I am not sure if this is a right direction to go in.  If a .C
> user of fsmonitor needs (does not need) things from dir.h, that file
> can (does not need to) include dir.h itself.

Hm; I was patterning based on existing .h files, which don't seem shy
about pulling in other .h files.

> I think this header does excessive "static inline" as premature
> optimization, so a better "fix" to your perceived problem may be to
> make them not "static inline".

Yeah, quite possibly.  Ben, do you recall your rationale for inlining
them in 6a6da08f6 ("fsmonitor: teach git to optionally utilize a file
system monitor to speed up detecting new or changed files.",
2017-09-22) ?

 - Alex

  reply	other threads:[~2017-12-20 20:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19  0:28 [PATCH 0/6] Minor fsmonitor bugfixes, use with `git diff` Alex Vandiver
2017-12-19  0:28 ` [PATCH 1/6] Fix comments to agree with argument name Alex Vandiver
2017-12-19  0:28   ` [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path Alex Vandiver
2017-12-19 20:17     ` Junio C Hamano
2017-12-20 20:59       ` Alex Vandiver [this message]
2017-12-21 21:47         ` Junio C Hamano
2017-12-19  0:28   ` [PATCH 3/6] fsmonitor: Update helper tool, now that flags are filled later Alex Vandiver
2017-12-20 21:12     ` Alex Vandiver
2017-12-19  0:28   ` [PATCH 4/6] fsmonitor: Add a trailing newline to test-dump-fsmonitor Alex Vandiver
2017-12-19 20:28     ` Junio C Hamano
2017-12-21  1:55       ` Alex Vandiver
2017-12-21 21:49         ` Junio C Hamano
2017-12-19  0:28   ` [PATCH 5/6] fsmonitor: Remove debugging lines from t/ Alex Vandiver
2017-12-19 20:19     ` Junio C Hamano
2017-12-20 17:35       ` Johannes Schindelin
2017-12-19  0:28   ` [PATCH 6/6] fsmonitor: Use fsmonitor data in `git diff` Alex Vandiver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1712201108190.10810@alexmv-linux \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).