From: Alex Vandiver <alexmv@dropbox.com>
To: Ben Peart <peartben@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index
Date: Fri, 15 Dec 2017 18:02:21 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1712151800010.7105@alexmv-linux> (raw)
In-Reply-To: <9b6679ea-b7e4-b45a-32bb-448cd2e891df@gmail.com>
On Mon, 13 Nov 2017, Ben Peart wrote:
> Why do you redirect stdout to stderr and then and perform an "echo"
> afterwards? I don't understand what benefit that provides. I removed this
> logic and the test still passes so am confused as to what its purpose is.
Ah -- the "echo" was purely to clean up STDERR as I was running the
test interactively. It serves no purpose, which is why it was hard
to understand its benefit. :)
Apologies for missing this (and in not replying here earlier!). I'll
send a commit that drops these.
- Alex
> > +# test that splitting the index dosn't interfere
> > +test_expect_success 'splitting the index results in the same state' '
> > + write_integration_script &&
> > + dirty_repo &&
> > + git update-index --fsmonitor &&
> > + git ls-files -f >expect &&
> > + test-dump-fsmonitor >&2 && echo &&
> > + git update-index --fsmonitor --split-index &&
> > + test-dump-fsmonitor >&2 && echo &&
> > + git ls-files -f >actual &&
> > + test_cmp expect actual
> > +'
> > +
> > test_done
next prev parent reply other threads:[~2017-12-16 2:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 19:58 [PATCH 0/2] fsmonitor: Stop reading from PWD, write fsmonitor+split index right Alex Vandiver
2017-11-09 19:58 ` [PATCH 1/2] fsmonitor: Read from getcwd(), not the PWD environment variable Alex Vandiver
2017-11-09 19:58 ` [PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index Alex Vandiver
2017-11-10 5:11 ` Junio C Hamano
2017-11-13 15:28 ` Ben Peart
2017-12-16 2:02 ` Alex Vandiver [this message]
2017-11-10 5:04 ` [PATCH 1/2] fsmonitor: Read from getcwd(), not the PWD environment variable Junio C Hamano
2017-11-10 21:03 ` [PATCH v1] fsmonitor: simplify determining the git worktree under Windows Ben Peart
2017-11-13 1:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1712151800010.7105@alexmv-linux \
--to=alexmv@dropbox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peartben@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).