From: Alex Vandiver <alexmv@dropbox.com>
To: Ben Peart <peartben@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree
Date: Thu, 26 Oct 2017 14:27:07 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1710261425390.9817@alexmv-linux> (raw)
In-Reply-To: <5a389621-961d-48e3-339a-ef182d3ed628@gmail.com>
On Thu, 26 Oct 2017, Ben Peart wrote:
> On 10/25/2017 9:31 PM, Alex Vandiver wrote:
> > diff --git a/fsmonitor.c b/fsmonitor.c
> > index 7c1540c05..0d26ff34f 100644
> > --- a/fsmonitor.c
> > +++ b/fsmonitor.c
> > @@ -121,6 +121,7 @@ static int query_fsmonitor(int version, uint64_t
> > last_update, struct strbuf *que
> > argv[3] = NULL;
> > cp.argv = argv;
> > cp.use_shell = 1;
> > + cp.dir = get_git_work_tree();
> >
>
> I'm not sure what would trigger this problem but I don't doubt that it is
> possible. Better to be safe than sorry. This is a better/faster solution than
> you're previous patch. Thank you!
See my response on the v1 of this series -- I'm curious how you're
_not_ seeing it, actually. Can you not replicate just by running
`git status` from differing parts of the working tree?
- Alex
next prev parent reply other threads:[~2017-10-26 21:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 1:31 [PATCH v2 0/4] fsmonitor fixes Alex Vandiver
2017-10-26 1:31 ` [PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree Alex Vandiver
2017-10-26 1:31 ` [PATCH v2 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman Alex Vandiver
2017-10-26 20:05 ` Ben Peart
2017-10-26 20:32 ` Ben Peart
2017-10-26 21:29 ` Alex Vandiver
2017-10-27 3:36 ` Ben Peart
2017-10-26 1:31 ` [PATCH v2 3/4] fsmonitor: Document GIT_TRACE_FSMONITOR Alex Vandiver
2017-10-26 1:31 ` [PATCH v2 4/4] fsmonitor: Delay updating state until after split index is merged Alex Vandiver
2017-10-26 20:29 ` Ben Peart
2017-10-26 1:33 ` [PATCH v2 1/4] fsmonitor: Set the PWD to the top of the working tree Alex Vandiver
2017-10-26 19:56 ` Ben Peart
2017-10-26 21:27 ` Alex Vandiver [this message]
2017-10-27 3:40 ` Ben Peart
2017-10-27 23:20 ` Alex Vandiver
2017-10-29 12:27 ` Johannes Schindelin
2017-10-29 12:31 ` [PATCH v2 0/4] fsmonitor fixes Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1710261425390.9817@alexmv-linux \
--to=alexmv@dropbox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peartben@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).