git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Anders Kaseorg <andersk@mit.edu>
To: Jeff King <peff@peff.net>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [BUG/PATCH] t9350-fast-export: Add failing test for symlink-to-directory
Date: Fri, 21 Aug 2015 12:47:30 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.10.1508211238570.31851@buzzword-bingo.mit.edu> (raw)
In-Reply-To: <20150821145827.GA565@sigill.intra.peff.net>

On Fri, 21 Aug 2015, Jeff King wrote:
>   - we may still have the opposite problem with renames. That is, a
>     rename is _also_ a deletion, but will go to the end. So I would
>     expect renaming the symlink "foo" to "bar" and then adding
>     "foo/world" would end up with:
> 
>        M 100644 :3 foo/world
>        R foo bar
> 
>     (because we push renames to the end in our sort). And indeed,
>     importing that does seem to get it wrong (we end up with "bar/world"
>     and no symlink).
> 
> We can't fix the ordering in the second case without breaking the first
> case. So I'm not sure it's fixable on the fast-export end.

Hmm, renames have a more fundamental ordering problem: swapping two 
(normal) files and using fast-export -C -B results in

  R foo bar
  R bar foo

which cannot be reimported correctly without fast-import fixes.

Anders

  reply	other threads:[~2015-08-21 16:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 19:46 [BUG/PATCH] t9350-fast-export: Add failing test for symlink-to-directory Anders Kaseorg
2015-08-21 14:58 ` Jeff King
2015-08-21 16:47   ` Anders Kaseorg [this message]
2015-08-24  5:25     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1508211238570.31851@buzzword-bingo.mit.edu \
    --to=andersk@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).