From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lang Subject: Re: Reviews on mailing-list Date: Sun, 11 Nov 2012 16:43:05 -0800 (PST) Message-ID: References: <20121111171451.GA26695@shrek.podlesie.net> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="680960-1982837929-1352680986=:19687" Cc: Krzysztof Mazur , Thiago Farina , Felipe Contreras , git@vger.kernel.org, Junio C Hamano , Shawn Pearce To: =?ISO-8859-15?Q?Deniz_T=FCrkoglu?= X-From: git-owner@vger.kernel.org Mon Nov 12 01:44:07 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TXi8D-0000Wv-Sd for gcvg-git-2@plane.gmane.org; Mon, 12 Nov 2012 01:44:06 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642Ab2KLAnw (ORCPT ); Sun, 11 Nov 2012 19:43:52 -0500 Received: from mail.lang.hm ([64.81.33.126]:51236 "EHLO bifrost.lang.hm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142Ab2KLAnw (ORCPT ); Sun, 11 Nov 2012 19:43:52 -0500 Received: from asgard.lang.hm (asgard.lang.hm [10.0.0.100]) by bifrost.lang.hm (8.13.4/8.13.4/Debian-3) with ESMTP id qAC0hixc022880; Sun, 11 Nov 2012 16:43:44 -0800 X-X-Sender: dlang@asgard.lang.hm In-Reply-To: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --680960-1982837929-1352680986=:19687 Content-Type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8BIT On Sun, 11 Nov 2012, Deniz Türkoglu wrote: > I understand from the feedback that gerrit should get better on making > it possible to review code via e-mail, as pointed out in Nguyen's > mail, a flow like Shawn mentioned[1] can be a good solution. > > FWIW, I can fetch the change(s) from gerrit I am interested in and > review it any time I want. I currently have many checked out topics I > am working on for instance. That requires that you know before you loose connectivity what changes you want to review. With e-mail based reviews, you just pull copies of all your mail and it includes any pending reviews along with everything else. David Lang --680960-1982837929-1352680986=:19687--