From: Daniel Stenberg <daniel@haxx.se>
To: Jeff King <peff@peff.net>
Cc: Stefan Beller <stefanbeller@googlemail.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: error: git-remote-https died of signal 13
Date: Mon, 25 Nov 2013 08:20:18 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.00.1311250815150.27300@tvnag.unkk.fr> (raw)
In-Reply-To: <20131125063945.GA16313@sigill.intra.peff.net>
On Mon, 25 Nov 2013, Jeff King wrote:
> Thanks. I'm having trouble reproducing the SIGPIPE locally, but I am able to
> see via strace the write we make in curl_multi_cleanup. The call stack is:
>
> curl_multi_cleanup
> -> close_all_connections
> -> Curl_disconnect
> -> Curl_ossl_close
> ...
>
> Daniel, does the call to Curl_disconnect need to be wrapped with
> sigpipe_ignore/reset, similar to 7d80ed64e435155?
Yes. It very much looks like that. The SSL "closing" is what was the problem I
had to adress.
But I then decided that if a 3rd library has one way to generate SIGPIPE it
may very well have another in a separate spot so I decided to do the wrap at
the top level immediately in the entry point when getting called by the
application. Following that, the SIGPIPE ignore/restore should rather be made
in curl_multi_cleanup.
--
/ daniel.haxx.se
next prev parent reply other threads:[~2013-11-25 7:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 16:36 error: git-remote-https died of signal 13 Stefan Beller
2013-11-24 6:54 ` Jeff King
2013-11-24 12:54 ` Stefan Beller
2013-11-24 13:33 ` Jeff King
2013-11-24 15:01 ` Stefan Beller
2013-11-24 15:54 ` Jeff King
2013-11-24 16:13 ` Stefan Beller
2013-11-24 16:32 ` Stefan Beller
2013-11-25 6:39 ` Jeff King
2013-11-25 7:20 ` Daniel Stenberg [this message]
2013-11-25 14:32 ` Jeff King
2013-11-25 14:35 ` [curl PATCH 1/2] factor out sigpipe_reset from easy.c Jeff King
2013-11-25 14:43 ` [curl PATCH 2/2] ignore SIGPIPE during curl_multi_cleanup Jeff King
2013-11-27 21:39 ` Daniel Stenberg
2018-05-22 10:26 ` curlUser
2018-05-22 10:50 ` Daniel Stenberg
[not found] ` <CAG4qzjti3MRXZ_Kofbb8b6whwDw7Se8g1VAe0mcU4ZdiWRfxpQ@mail.gmail.com>
2018-05-22 15:06 ` Daniel Stenberg
2018-05-22 15:01 ` curlUser
2018-08-03 12:29 ` dxt29
2013-11-25 14:46 ` error: git-remote-https died of signal 13 Jeff King
2013-11-24 22:13 ` Daniel Stenberg
2013-11-24 23:51 ` brian m. carlson
-- strict thread matches above, loose matches on Subject: below --
2014-04-21 0:42 Greg M
2014-04-23 6:59 ` Jeff King
2014-04-23 11:49 ` Greg M
2014-04-24 4:15 ` Jeff King
2014-04-24 12:11 ` Greg M
2014-04-24 12:15 ` Daniel Stenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1311250815150.27300@tvnag.unkk.fr \
--to=daniel@haxx.se \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=stefanbeller@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).