From: Peter Krefting <peter@softwolves.pp.se>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Git Mailing List <git@vger.kernel.org>, gitster@pobox.com
Subject: Re: [PATCH v2 1/2] commit: reject invalid UTF-8 codepoints
Date: Fri, 5 Jul 2013 13:51:03 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.00.1307051345260.11814@ds9.cixit.se> (raw)
In-Reply-To: <20130704171943.GA267700@vauxhall.crustytoothpaste.net>
brian m. carlson:
> + /* U+FFFE and U+FFFF are guaranteed non-characters. */
> + if ((codepoint & 0x1ffffe) == 0xfffe)
> + return bad_offset;
I missed this the first time around: All Unicode characters whose
lower 16-bits are FFFE or FFFF are non-characters, so you can re-write
that to:
/* U+xxFFFE and U+xxFFFF are guaranteed non-characters. */
if ((codepoint & 0xfffe) == 0xfffe)
return bad_offset;
Also, the range U+FDD0--U+FDEF are also non-characters, if you wish to
be really pedantic.
$ grep '^[0-9A-F].*<not a' NamesList.txt
FDD0 <not a character>
FDD1 <not a character>
FDD2 <not a character>
FDD3 <not a character>
FDD4 <not a character>
FDD5 <not a character>
FDD6 <not a character>
FDD7 <not a character>
FDD8 <not a character>
FDD9 <not a character>
FDDA <not a character>
FDDB <not a character>
FDDC <not a character>
FDDD <not a character>
FDDE <not a character>
FDDF <not a character>
FDE0 <not a character>
FDE1 <not a character>
FDE2 <not a character>
FDE3 <not a character>
FDE4 <not a character>
FDE5 <not a character>
FDE6 <not a character>
FDE7 <not a character>
FDE8 <not a character>
FDE9 <not a character>
FDEA <not a character>
FDEB <not a character>
FDEC <not a character>
FDED <not a character>
FDEE <not a character>
FDEF <not a character>
FFFE <not a character>
FFFF <not a character>
1FFFE <not a character>
1FFFF <not a character>
2FFFE <not a character>
2FFFF <not a character>
3FFFE <not a character>
3FFFF <not a character>
4FFFE <not a character>
4FFFF <not a character>
5FFFE <not a character>
5FFFF <not a character>
6FFFE <not a character>
6FFFF <not a character>
7FFFE <not a character>
7FFFF <not a character>
8FFFE <not a character>
8FFFF <not a character>
9FFFE <not a character>
9FFFF <not a character>
AFFFE <not a character>
AFFFF <not a character>
BFFFE <not a character>
BFFFF <not a character>
CFFFE <not a character>
CFFFF <not a character>
DFFFE <not a character>
DFFFF <not a character>
EFFFE <not a character>
EFFFF <not a character>
FFFFE <not a character>
FFFFF <not a character>
10FFFE <not a character>
10FFFF <not a character>
--
\\// Peter - http://www.softwolves.pp.se/
next prev parent reply other threads:[~2013-07-05 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 17:17 [PATCH v2 0/2] commit: improve UTF-8 validation brian m. carlson
2013-07-04 17:19 ` [PATCH v2 1/2] commit: reject invalid UTF-8 codepoints brian m. carlson
2013-07-04 19:58 ` Torsten Bögershausen
2013-07-04 20:39 ` brian m. carlson
2013-07-05 12:51 ` Peter Krefting [this message]
2013-07-08 19:36 ` Junio C Hamano
2013-07-09 11:16 ` [PATCH] commit: reject non-characters Peter Krefting
2013-08-05 12:48 ` Peter Krefting
2013-08-05 16:54 ` Junio C Hamano
2013-08-06 7:03 ` Peter Krefting
2013-07-04 17:20 ` [PATCH v2 2/2] commit: reject overlong UTF-8 sequences brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1307051345260.11814@ds9.cixit.se \
--to=peter@softwolves.pp.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).