git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Martin Storsjö" <martin@martin.st>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Tay Ray Chuan <rctay89@gmail.com>,
	L?na?c Huard <lenaic@lhuard.fr.eu.org>,
	git@vger.kernel.org
Subject: Re: [PATCH] Allow git to use any HTTP authentication method.
Date: Mon, 28 Dec 2009 17:50:12 +0200 (EET)	[thread overview]
Message-ID: <alpine.DEB.2.00.0912281745540.5582@cone.home.martin.st> (raw)
In-Reply-To: <20091228153701.GA2252@spearce.org>

On Mon, 28 Dec 2009, Shawn O. Pearce wrote:

> Uh, stupid question, but why must we enable this option?  I don't
> have to enable something in my browser before I use digest auth to
> visit a website, why do I need to enable it in git?
> 
> How does one use git clone with an http:// URL with digest
> authentication?  Its not obvious to the user that you would need
> to first export an obtuse environment variable to get something
> that should Just Work(tm).
> 
> Yes, I realize you may need to perform an extra HTTP request to
> start the transaction, but why aren't we doing that?  Isn't it only
> 1 additional request to discover the desired authentication method?

Initially when I added support for this, curl sessions weren't reused, so 
every single request had to be duplicated if authentication was used, 
adding quite a bit of overhead.

Now that sessions are reused properly, I tend to agree that this should be 
enabled automatically.

Any other opinions on this, Tay or Junio?

Should I send in a new patch that removes the http.authAny option and 
always enables this, or send a rewritten version of the patch that already 
is in 'next'?

// Martin

  reply	other threads:[~2009-12-28 15:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-28 10:54 [PATCH] Allow git to use any HTTP authentication method Lénaïc Huard
2009-12-28 12:09 ` Martin Storsjö
2009-12-28 12:12   ` Tay Ray Chuan
2009-12-28 15:37     ` Shawn O. Pearce
2009-12-28 15:50       ` Martin Storsjö [this message]
2009-12-28 15:53         ` Shawn O. Pearce
2009-12-28 17:15           ` Tay Ray Chuan
2009-12-28 18:04             ` Junio C Hamano
2009-12-28 18:10               ` Martin Storsjö
2009-12-28 18:15               ` Shawn O. Pearce
2009-12-28 12:37 ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0912281745540.5582@cone.home.martin.st \
    --to=martin@martin.st \
    --cc=git@vger.kernel.org \
    --cc=lenaic@lhuard.fr.eu.org \
    --cc=rctay89@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).