git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 3/6] Facilitate debugging Git executables in tests with gdb
Date: Fri, 30 Oct 2015 19:25:24 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.1.00.1510301923010.31610@s15462909.onlinehome-server.info> (raw)
In-Reply-To: <20151027232848.GA4172@sigill.intra.peff.net>

Hi Peff,

On Tue, 27 Oct 2015, Jeff King wrote:

> On Tue, Oct 27, 2015 at 09:34:48AM -0700, Junio C Hamano wrote:
> 
> > Yeah, that was my first reaction when I saw this patch.  Instead of
> > having to munge that line to "gdb -whatever-args git", you can do a
> > single-shot debugging in a convenient way.  And quite honestly,
> > because nobody sane will run:
> > 
> >      $ cd t && TEST_GDB_GIT=1 sh ./t1234-frotz.sh
> > 
> > and can drive all the "git" running under gdb at the same time, I
> > think what you showed would be the _only_ practical use case.
> 
> I agree doing so would be crazy. But would:
> 
>   ./t1234-frotz.sh --gdb=17
> 
> be sane to run gdb only inside test 17?

It would probably be sane, but I never encountered the need for something
like that. It was always much easier to run the test using `sh -x t... -i
-v` to find out what command was behaving funnily (mind you, that can be a
pretty hard thing todo, we have some quite convoluted test scripts in our
code base) and then edit the test.

I would expect that `--gdb=<n>` thing to drive me crazy: first, I would
choose the wrong number. Next, I would probably forget that test_commit
and other commands *also* calls Git.

Ciao,
Dscho

  parent reply	other threads:[~2015-10-30 18:25 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26 13:14 [PATCH 0/6] Miscellaneous platform-independent patches from Git for Windows Johannes Schindelin
2015-10-26 13:14 ` [PATCH 1/6] Only use CURLOPT_LOGIN_OPTIONS if it is actually available Johannes Schindelin
2015-10-26 20:17   ` Junio C Hamano
2015-10-26 13:15 ` [PATCH 2/6] remote-http(s): Support SOCKS proxies Johannes Schindelin
2015-10-26 20:15   ` Junio C Hamano
2015-10-27  1:23     ` James McCoy
2015-10-27  1:40       ` Junio C Hamano
2015-10-27 15:50         ` Johannes Schindelin
2015-10-27 15:53           ` Johannes Schindelin
2015-10-27 17:27             ` Junio C Hamano
2015-10-27 19:38               ` Junio C Hamano
2015-10-27 21:01                 ` Junio C Hamano
2015-10-30 18:38                 ` Johannes Schindelin
2015-11-09 22:28             ` Pat Thoyts
2015-11-16 21:49               ` Johannes Schindelin
2015-11-18  6:52               ` Junio C Hamano
2015-10-26 13:15 ` [PATCH 3/6] Facilitate debugging Git executables in tests with gdb Johannes Schindelin
2015-10-26 19:17   ` Jonathan Nieder
2015-10-27  9:42     ` Johannes Schindelin
2015-10-27 16:34       ` Junio C Hamano
2015-10-27 23:28         ` Jeff King
2015-10-27 23:39           ` Stefan Beller
2015-10-27 23:58             ` Jeff King
2015-10-30 18:25           ` Johannes Schindelin [this message]
2015-10-30 19:26             ` Jeff King
2015-10-30 18:27         ` Johannes Schindelin
2015-10-30 18:32           ` Junio C Hamano
2015-10-30 19:02             ` Jonathan Nieder
2015-10-30 19:14               ` Johannes Schindelin
2015-10-30 19:56               ` Jeff King
2015-10-30 21:30                 ` Jonathan Nieder
2015-10-30 21:53                 ` Junio C Hamano
2015-10-30 18:31       ` Johannes Schindelin
2015-10-30 18:55         ` Jonathan Nieder
2015-10-27 18:09   ` Duy Nguyen
2015-10-29 16:44     ` Junio C Hamano
2015-10-29  5:15   ` Victor Leschuk
2015-10-30 18:42     ` Johannes Schindelin
2015-11-01  5:31       ` Victor Leschuk
2015-11-01 13:37         ` Johannes Schindelin
2015-10-26 13:15 ` [PATCH 4/6] Squelch warning about an integer overflow Johannes Schindelin
2015-10-26 20:23   ` Junio C Hamano
2015-10-30 18:18     ` Johannes Schindelin
2015-10-30 18:21       ` Junio C Hamano
2015-10-26 13:15 ` [PATCH 5/6] Silence GCC's "cast of pointer to integer of a different size" warning Johannes Schindelin
2015-10-26 20:20   ` Junio C Hamano
2015-10-26 13:15 ` [PATCH 6/6] Correct fscanf formatting string for I64u values Johannes Schindelin
2015-10-26 20:20   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.1510301923010.31610@s15462909.onlinehome-server.info \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).