From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Lars Hjemli <hjemli@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Subject: Re: [RFC/PATCH v3 3/3] archive.c: add basic support for submodules
Date: Fri, 23 Jan 2009 20:57:55 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.1.00.0901232054360.21467@intel-tinevez-2-302> (raw)
In-Reply-To: <8c5c35580901231040i380c6458x1a6103cd6f55c479@mail.gmail.com>
Hi,
On Fri, 23 Jan 2009, Lars Hjemli wrote:
> On Fri, Jan 23, 2009 at 00:44, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> > On Thu, 22 Jan 2009, Lars Hjemli wrote:
> >
> >> The new --submodules option is used to trigger inclusion of checked out
> >> submodules in the archive.
> >>
> >> The implementation currently does not verify that the submodule has
> >> been registered as 'interesting' in .git/config, neither does it
> >> resolve the currently checked out submodule HEAD but instead uses the
> >> commit SHA1 recorded in the gitlink entry to identify the submodule
> >> root tree.
> >
> > Please understand that I skipped the rest of the patch.
>
> That's too bad, I hoped on some feedback from you on the part of the
> commit message which you didn't quote:
Well, you ignored my comments, so what do you expect me to do? Be happy?
There are two issues there:
- presence of a specific commit object being present in the repository
does not necessarily mean that it is reachable by any ref, and therefore
can mean that the tree/blob objects are not reachable, because it could
be an interrupted fetch; in all of Git, we try to assume that only
reachable objects are valid objects.
- presence of a specific commit in the supermodule is a _lousy_ indicator
that the user wants to include that submodule in the archive.
Until both issues are addresse, I will not dance a little song and be
merry over this issue.
Ciao,
Dscho
next prev parent reply other threads:[~2009-01-23 19:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 21:17 [RFC/PATCH v3 0/3] Add support for `git archive --submodules` Lars Hjemli
2009-01-22 21:17 ` [RFC/PATCH v3 1/3] tree.c: teach read_tree_recursive how to traverse gitlink entries Lars Hjemli
2009-01-22 21:17 ` [RFC/PATCH v3 2/3] sha1_file: prepare for adding alternates on demand Lars Hjemli
2009-01-22 21:17 ` [RFC/PATCH v3 3/3] archive.c: add basic support for submodules Lars Hjemli
2009-01-22 23:44 ` Johannes Schindelin
2009-01-23 18:40 ` Lars Hjemli
2009-01-23 19:23 ` Junio C Hamano
2009-01-23 20:15 ` Lars Hjemli
2009-01-23 20:50 ` Junio C Hamano
2009-01-23 21:15 ` Lars Hjemli
2009-01-23 19:57 ` Johannes Schindelin [this message]
2009-01-24 8:44 ` Lars Hjemli
2009-01-24 13:51 ` Johannes Schindelin
2009-01-24 19:26 ` Lars Hjemli
2009-01-24 19:52 ` Johannes Schindelin
2009-01-24 20:02 ` Lars Hjemli
2009-01-22 23:43 ` [RFC/PATCH v3 2/3] sha1_file: prepare for adding alternates on demand Johannes Schindelin
2009-01-23 18:35 ` Lars Hjemli
2009-01-23 19:54 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0901232054360.21467@intel-tinevez-2-302 \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hjemli@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).