From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Fredrik Tolf <fredrik@dolda2000.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] Ensure that SSH runs in non-interactive mode
Date: Mon, 21 Jul 2008 03:15:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.0807210310330.3305@eeepc-johanness> (raw)
In-Reply-To: <1216598432-18553-1-git-send-email-fredrik@dolda2000.com>
Hi,
On Mon, 21 Jul 2008, Fredrik Tolf wrote:
> I'm following my previous SSH patch up with this one, which should at
> least solve the problems discussed, and probably some more. If anything,
> it might be considered a bit overkill for the problem at hand.
I am not assuming it is overkill, but since you do not reuse functions
such as strbuf_expand() and split_cmdline(), your patch ends up pretty
large.
And since you use very short and undescriptive variable names, with ugly
assignments inside arithmetic expressions, I will be less likely
reviewing it in detail.
> I assume it might have to be documented as well, if people approve of it.
Catch 22. Since you have not documented what %P should be useful for,
people might not approve of the patch, because they do not understand what
it is supposed to do.
People like me,
Dscho
next prev parent reply other threads:[~2008-07-21 1:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 0:00 [PATCH v2] Ensure that SSH runs in non-interactive mode Fredrik Tolf
2008-07-21 1:15 ` Johannes Schindelin [this message]
2008-07-21 1:44 ` Fredrik Tolf
2008-07-21 8:38 ` Jakub Narebski
2008-07-21 10:56 ` Johannes Schindelin
2008-07-21 11:04 ` Jeff King
2008-07-21 11:22 ` Johannes Schindelin
2008-07-21 13:04 ` Fredrik Tolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0807210310330.3305@eeepc-johanness \
--to=johannes.schindelin@gmx.de \
--cc=fredrik@dolda2000.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).