Re: [PATCH 06/12] connect: Fix custom ports with plink (Putty's ssh)

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi,

On Wed, 2 Jul 2008, Edward Z. Yang wrote:

> Johannes Sixt wrote:
> > What about installing a wrapper script, plinkssh, that does this:
> > [snip]
> 
> Well, the patch is shorter :-)

But you have to do it for every SSH backend that you might want to 
support.

And you have to recompile.

> 1. It's been tested, it works. I haven't tried the script yet, so I 
>    don't know if it works.

Sorry, that argument does not fly.  "My patch is better, because I did not 
test your patch."

> 2. Git historically doesn't use bash, so the script would have to be 
>    rewritten in Perl or plain sh or tcl or something.

That is so totally untrue.  We have Perl scripts and Shell scripts (for 
which we need the bash), and then we have the two GUIs which use Tcl/Tk.

Actually, we only have so few Perl scripts left that it might be possible 
to ship a version of Git on Windows without Perl.  The only script that 
needs to be converted to a builtin is add -i.

The rest of the scripts are shell.

So this argument is totally bogus.

> 3. It's less brittle than the wrapper script if we decide to have Git 
>    pass more params to OpenSSH.

Granted, should we decide one day to use more elaborate features of 
OpenSSH, then we would have to change the script, too.

But most likely, Plink support would be broken by that update _anyway_, 
since it does not grok the OpenSSH options directly.

And guess what is easier to fix, a script that rewrites the arguments from 
OpenSSH syntax to Plink syntax, or a C program with over 78,000 code 
lines that has to be recompiled?

> 4. It's "more native".

Would it not be even more native if we just linked in libssl?  Would you 
write the patch?

Further, would you like to convert and maintain all people's wrapper 
scripts to C code inside Git?

BTW what is the reason why Hannes' mail does not appear to be the mail 
you replied to in GMane, but the patch Steffen sent?

Ciao,
Dscho