From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [NON-TOY PATCH] git bisect: introduce 'fixed' and 'unfixed'
Date: Tue, 24 Jun 2008 20:26:55 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.1.00.0806242026441.9925@racer> (raw)
In-Reply-To: <alpine.LNX.1.00.0806241516440.19665@iabervon.org>
Hi,
On Tue, 24 Jun 2008, Daniel Barkalow wrote:
> On Tue, 24 Jun 2008, Jeff King wrote:
>
> > On Tue, Jun 24, 2008 at 06:09:28PM +0100, Johannes Schindelin wrote:
> >
> > > And this is my first attempt at a proper patch for it.
> > >
> > > Now with documentation, and hopefully all places where the
> > > user is being told about a "bad" commit.
> >
> > This looks reasonably sane to me. The only thing I can think of that
> > we're missing is that "git bisect visualize" will still show the refs as
> > "bisect/bad" and "bisect/good".
> >
> > To fix that, you'd have to ask people to start the bisect by saying "I
> > am bisecting to find a fix, not a breakage." And then you could change
> > the refnames and all of the messages as appropriate.
>
> That would also be a good way of taking care of the problem where someone
> gets distracted while running a slow test, forgets what they're looking
> for, and marks the result as "bad" instead of "unfixed".
Feel free to rework my patch.
Ciao,
Dscho
next prev parent reply other threads:[~2008-06-24 19:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 14:17 [TOY PATCH] git bisect: introduce 'fixed' and 'unfixed' Johannes Schindelin
2008-06-24 14:42 ` Stephan Beyer
2008-06-24 14:55 ` Johannes Schindelin
2008-06-24 15:16 ` Stephan Beyer
2008-06-24 15:02 ` Nicolas Pitre
2008-06-24 16:38 ` Jeff King
2008-06-24 16:50 ` Johannes Schindelin
2008-06-24 17:09 ` [NON-TOY " Johannes Schindelin
2008-06-24 17:41 ` Jeff King
2008-06-24 19:22 ` Daniel Barkalow
2008-06-24 19:26 ` Johannes Schindelin [this message]
2008-06-24 22:30 ` Junio C Hamano
2008-06-27 13:48 ` [PATCH, next version] " Johannes Schindelin
2008-06-27 23:03 ` Junio C Hamano
2008-06-28 13:48 ` Johannes Schindelin
2008-06-28 17:52 ` Junio C Hamano
2008-06-24 19:59 ` [NON-TOY PATCH] " SZEDER Gábor
2008-06-24 20:06 ` Michael Haggerty
2008-06-24 20:38 ` Johannes Schindelin
2008-06-24 22:31 ` Junio C Hamano
2008-06-24 22:43 ` Nicolas Pitre
2008-06-26 6:03 ` Christian Couder
2008-06-24 22:48 ` Lea Wiemann
2008-06-24 23:53 ` A Large Angry SCM
2008-06-25 7:27 ` Karl Hasselström
2008-06-24 16:54 ` [TOY " Reini Urban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0806242026441.9925@racer \
--to=johannes.schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).