From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 374C51F47D for ; Fri, 6 Jan 2023 20:37:54 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=KeKDSqis; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236401AbjAFUhH (ORCPT ); Fri, 6 Jan 2023 15:37:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230308AbjAFUgz (ORCPT ); Fri, 6 Jan 2023 15:36:55 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C605C09 for ; Fri, 6 Jan 2023 12:36:53 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id m7so2347810wrn.10 for ; Fri, 06 Jan 2023 12:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=iNFrRUzAOuNSF8t1leDfh9Tj6xawIPV4QkdV6yQMg+U=; b=KeKDSqisfxKZd4BVngSHCJnSKqJhF0u88n/Fbap/saTgPxPexumr75gB8Ju+UIHGbu +2hwWtkS5rFm9Tl/Vc4Kxnsj9VWGeje6hFC9u/kwFSFC4FoMCIq0kjXkF8bXAixQDebz bX0+mZkN+Tck6cBnO4/mbcZzFG5qr4lHmtBcUoA8oCsJ/rJ+ZGmBPW08zMEiaMHC8cii bGi6KIyPx832Vi9oJMMln+2ENd6tAuIeRpy17wpAfBasn8JMEq+ao+iNCftp/VNjg/sb iHt/U+AX4rkDpb7NjfQtKcQ/JUV/ThR0c7BA2TRc86FBAwxrnKYLU8XQDbqUAxAbfD8H Mg6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iNFrRUzAOuNSF8t1leDfh9Tj6xawIPV4QkdV6yQMg+U=; b=u4WenS4wLpHo0LydX8aAqENhghF0YOFApiHhQCLf3jwmj/B7YlwwIZwr+ISzSVsecy DWC5iSBTrTKIaalZGIByNnXoEW3MSdkNdmRK21eMacqUUp8NOpILljB45D/53cNh6w/W 1e6NNPS7shDBy0q+vs2/OkZxN66onX4F17r6PJxkzI+ar/F9I1WKWX6US9ug9VL+TtEi 39uirervLDQcMiHRaXXDnjtToo/vh4l1/LHnEoE8Ei1mYWe2eKKaVOnbizGoFRwkhPha EdLDDWcaYnuNKAVJFGz2ITJRpd1evR5DLvGubYmZUs6sBSPgboKJ5YDcjgr3s1df5u/i Gfdw== X-Gm-Message-State: AFqh2kpvoBdMXPB0VQqKsq/zU6Bq30E2GitZLoF/KMueCOFPLeFoMJvj AIsQqjcRd+hVriUL+TpaNqMszCPhC3o= X-Google-Smtp-Source: AMrXdXtJ8Xq6q/UzINg6CRiIcb6DdWOJzjr6SVSaLP/3TBtJzYBV5cf2BMGdv33IyJnlM7r6xyCv5A== X-Received: by 2002:a5d:54ce:0:b0:242:8bc1:fa08 with SMTP id x14-20020a5d54ce000000b002428bc1fa08mr32879054wrv.27.1673037411949; Fri, 06 Jan 2023 12:36:51 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id i6-20020adfe486000000b002423dc3b1a9sm2030635wrm.52.2023.01.06.12.36.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 12:36:51 -0800 (PST) Message-Id: In-Reply-To: References: From: "Derrick Stolee via GitGitGadget" Date: Fri, 06 Jan 2023 20:36:43 +0000 Subject: [PATCH 6/8] bundle-uri: drop bundle.flag from design doc Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: gitster@pobox.com, me@ttaylorr.com, vdye@github.com, avarab@gmail.com, steadmon@google.com, chooglen@google.com, Derrick Stolee , Derrick Stolee Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Derrick Stolee The Implementation Plan section lists a 'bundle.flag' option that is not documented anywhere else. What is documented elsewhere in the document and implemented by previous changes is the 'bundle.heuristic' config key. For now, a heuristic is required to indicate that a bundle list is organized for use during 'git fetch', and it is also sufficient for all existing designs. Signed-off-by: Derrick Stolee --- Documentation/technical/bundle-uri.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/technical/bundle-uri.txt b/Documentation/technical/bundle-uri.txt index b78d01d9adf..91d3a13e327 100644 --- a/Documentation/technical/bundle-uri.txt +++ b/Documentation/technical/bundle-uri.txt @@ -479,14 +479,14 @@ outline for submitting these features: (This choice is an opt-in via a config option and a command-line option.) -4. Allow the client to understand the `bundle.flag=forFetch` configuration +4. Allow the client to understand the `bundle.heuristic` configuration key and the `bundle..creationToken` heuristic. When `git clone` - discovers a bundle URI with `bundle.flag=forFetch`, it configures the - client repository to check that bundle URI during later `git fetch ` + discovers a bundle URI with `bundle.heuristic`, it configures the client + repository to check that bundle URI during later `git fetch ` commands. 5. Allow clients to discover bundle URIs during `git fetch` and configure - a bundle URI for later fetches if `bundle.flag=forFetch`. + a bundle URI for later fetches if `bundle.heuristic` is set. 6. Implement the "inspect headers" heuristic to reduce data downloads when the `bundle..creationToken` heuristic is not available. -- gitgitgadget