From: "Santi Béjar" <santi@agolina.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] git-parse-remote: remove unused functions
Date: Sat, 6 Jun 2009 23:03:47 +0200 [thread overview]
Message-ID: <adf1fd3d0906061403sd13200co286e986c67135f4b@mail.gmail.com> (raw)
In-Reply-To: <7v63f9cd4s.fsf@alter.siamese.dyndns.org>
2009/6/6 Junio C Hamano <gitster@pobox.com>:
> Santi Béjar <santi@agolina.net> writes:
>
>> Signed-off-by: Santi Béjar <santi@agolina.net>
>> ---
>> .gitignore | 1 -
>> Documentation/git-parse-remote.txt | 50 ---------
>> git-parse-remote.sh | 204 ------------------------------------
>> 3 files changed, 0 insertions(+), 255 deletions(-)
>> delete mode 100644 Documentation/git-parse-remote.txt
>
> I do not understand this patch.
>
> With this patch remove git-parse-remote from .gitignore (as if the entire
> file is going away)
Ops, the .gitignore removal was a mistake.
> and its documentation (again as if the entire file is
> going away), so naturally I would have expected to see removal of the file
> in the patch as well (and that means Makefile needs to be touched), but
> that is not what is happening.
I just wanted to remove the unused functions, and their documentation.
But I was removing the two functions that were documented, so I
removed all the file. Maybe I can just remove their documentation and
leave the rest of the file.
Santi
prev parent reply other threads:[~2009-06-06 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 19:53 [PATCH 3/3] git-parse-remote: remove unused functions Santi Béjar
2009-06-06 20:37 ` Junio C Hamano
2009-06-06 21:03 ` Santi Béjar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adf1fd3d0906061403sd13200co286e986c67135f4b@mail.gmail.com \
--to=santi@agolina.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).