From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH 1/1] Windows: force-recompile git.res for differing architectures
Date: Wed, 7 Nov 2018 07:55:38 +0100 [thread overview]
Message-ID: <ad98ab16-c6bf-7294-f498-d0e7295105fc@kdbg.org> (raw)
In-Reply-To: <xmqqk1lpd65h.fsf@gitster-ct.c.googlers.com>
Am 07.11.18 um 02:32 schrieb Junio C Hamano:
> Johannes Sixt <j6t@kdbg.org> writes:
>> On Linux, when I recompile for a different architecture, CFLAGS would
>> change, so I would have thought that GIT-CFLAGS were the natural
>> choice for a dependency. Don't they change in this case on Windows,
>> too?
>
> Depending on GIT-CFLAGS would have a better chance of being safe, I
> guess, even though it can at times be overly safe, than GIT-PREFIX,
> I suspect. As a single user target in Makefile, which is only used
> by Dscho, who intends to stick to /mingw(32|64)/ convention til the
> end of time, I think the posted patch is OK, though.
I think that it's not only Dscho who uses the target (my build
environment, for example, is different from Dscho's and compiles
git.res, too). But since the patch helps him most and doesn't hurt
others, it is good to go. No objection from my side.
-- Hannes
next prev parent reply other threads:[~2018-11-07 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 14:55 [PATCH 0/1] Windows: force-recompile git.res for differing architectures Johannes Schindelin via GitGitGadget
2018-11-06 14:55 ` [PATCH 1/1] " Johannes Schindelin via GitGitGadget
2018-11-06 21:44 ` Johannes Sixt
2018-11-07 1:32 ` Junio C Hamano
2018-11-07 6:55 ` Johannes Sixt [this message]
2018-11-07 9:03 ` Junio C Hamano
2018-11-07 11:25 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad98ab16-c6bf-7294-f498-d0e7295105fc@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).