From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
stas@stason.org, "Git Mailing List" <git@vger.kernel.org>
Subject: Re: git silently ignores include directive with single quotes
Date: Sat, 8 Sep 2018 23:10:44 +0100 [thread overview]
Message-ID: <ad56c575-1211-61d2-daed-5b0da61db738@ramsayjones.plus.com> (raw)
In-Reply-To: <20180908211436.GA31560@sigill.intra.peff.net>
On 08/09/18 22:14, Jeff King wrote:
> On Sat, Sep 08, 2018 at 09:54:14PM +0200, Ævar Arnfjörð Bjarmason wrote:
>
>> The reason missing includes are ignored is that the way this is expected
>> to be used is e.g.:
>>
>> [include]
>> path ~/.gitconfig.work
>>
>> Where .gitconfig.work is some configuration you're going to drop into
>> place on your $dayjob servers, but not on your personal machine, even
>> though you sync the same ~/.gitconfig everywhere.
>>
>> A lot of people who use includes rely on this, but I see from this
>> thread this should be better documented.
>
> Right, this was an intentional choice at the time the feature was added,
> to support this kind of feature. I'd note also that it mirrors other
> misspelled keys. E.g.:
>
> [include]
> psth = whatever
>
[snip]
> That said, it _does_ behave the same and people are likely depending on
> it at this point. So if we introduce a warning, for example, there needs
> to be some way to suppress it.
>
> Probably:
>
> [include]
> warnOnMissing = false
> path = ...
I was going to suggest, inspired by Makefile syntax, that
[-include] would not complain if the file was missing ...
except, of course, it's too late for that! ;-)
I suppose [+include] could complain if the file is missing
instead, ... dunno.
ATB,
Ramsay Jones
next prev parent reply other threads:[~2018-09-08 22:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 18:58 git silently ignores include directive with single quotes Stas Bekman
2018-09-08 19:30 ` Martin Ågren
2018-09-08 19:44 ` Stas Bekman
2018-09-08 19:53 ` Stas Bekman
2018-09-08 20:02 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:13 ` Stas Bekman
2018-09-08 20:28 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:58 ` Stas Bekman
2018-09-09 2:51 ` Paul Smith
2018-09-09 2:57 ` Stas Bekman
2018-09-08 19:54 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:04 ` Stas Bekman
2018-09-08 20:16 ` Ævar Arnfjörð Bjarmason
2018-09-08 21:14 ` Jeff King
2018-09-08 22:10 ` Ramsay Jones [this message]
2018-09-09 2:33 ` Jeff King
2018-09-11 20:36 ` Junio C Hamano
2018-09-11 20:57 ` Jeff King
2018-09-23 22:48 ` Stas Bekman
2018-09-24 21:08 ` Ævar Arnfjörð Bjarmason
2018-09-24 23:20 ` Stas Bekman
2018-09-24 22:24 ` [PATCH 0/1] " Philip Oakley
2018-09-24 23:05 ` Stas Bekman
2018-09-24 22:24 ` [PATCH 1/1] config doc: highlight the name=value syntax Philip Oakley
2018-09-25 22:03 ` Junio C Hamano
2018-09-08 22:32 ` git silently ignores include directive with single quotes Ævar Arnfjörð Bjarmason
2018-09-09 2:29 ` Jeff King
2018-09-08 21:22 ` Jeff King
2018-09-08 22:49 ` Stas Bekman
2018-09-09 2:30 ` Jeff King
2018-09-10 17:04 ` Junio C Hamano
2018-09-10 17:14 ` Jonathan Nieder
2018-09-10 18:30 ` Junio C Hamano
2018-09-10 18:35 ` Jonathan Nieder
2018-09-10 19:17 ` Junio C Hamano
2018-09-10 19:52 ` Stas Bekman
2018-09-10 20:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad56c575-1211-61d2-daed-5b0da61db738@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=peff@peff.net \
--cc=stas@stason.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).