From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 8C5A11F9FD for ; Wed, 24 Feb 2021 07:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232993AbhBXHVV (ORCPT ); Wed, 24 Feb 2021 02:21:21 -0500 Received: from [93.83.142.38] ([93.83.142.38]:42264 "EHLO localhost" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S232329AbhBXHVU (ORCPT ); Wed, 24 Feb 2021 02:21:20 -0500 Received: from [IPv6:::1] (localhost [IPv6:::1]) by localhost (Postfix) with ESMTP id 2131729CD6; Wed, 24 Feb 2021 08:20:57 +0100 (CET) Subject: Re: [PATCH] wrapper: add workaround for open() returning EINTR To: Jeff King , git@vger.kernel.org Cc: Aleksey Kliger References: From: Johannes Sixt Message-ID: Date: Wed, 24 Feb 2021 08:20:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Am 24.02.21 um 05:43 schrieb Jeff King: > The workaround here is enabled all the time, without a Makefile knob, > since it's a complete noop if open() never returns EINTR. I did push it > into its own compat/ source file, though, since it has to #undef our > macro redirection. Putting it in a file with other code risks confusion > if more code is added after that #undef. I'm not so much opposed to "enable it all the time" in general, but when we already have an override of open(), like for the Windows case in compat/mingw.h, I find it a bit rough to put another wrapper around it, even more so since we won't have the EINTR problem on Windows due to the absence of signals. -- Hannes