From: Derrick Stolee <stolee@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Cc: "Jeff King" <peff@peff.net>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v5 00/12] Hash-independent tests (part 3)
Date: Thu, 13 Sep 2018 13:00:34 -0400 [thread overview]
Message-ID: <abd21e68-ac72-3111-5813-7d47af3d6aa6@gmail.com> (raw)
In-Reply-To: <20180913051742.252276-1-sandals@crustytoothpaste.net>
On 9/13/2018 1:17 AM, brian m. carlson wrote:
> This is the next in the series of improvements to make tests
> hash-independent.
>
> A range-diff is below.
>
> Changes from v4:
> * Add local statements to the &&-chain.
> * Fix a typo in the local statement.
> * Add a helpful comment about why test_detect_hash is hard-coded to
> SHA-1.
The range-diff and these changes since v4 are reasonable. I'm happy with
the current version.
I'm looking forward to this change getting merged down, as I also want
to use 'test_oid rawsz' for the 'git multi-pack-index verify' tests that
are currently under review (v2 imminent).
Thanks,
-Stolee
prev parent reply other threads:[~2018-09-13 17:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 5:17 [PATCH v5 00/12] Hash-independent tests (part 3) brian m. carlson
2018-09-13 5:17 ` [PATCH v5 01/12] t: add test functions to translate hash-related values brian m. carlson
2018-09-13 5:17 ` [PATCH v5 02/12] t0000: use hash translation table brian m. carlson
2018-09-13 5:17 ` [PATCH v5 03/12] t0000: update tests for SHA-256 brian m. carlson
2018-09-13 5:17 ` [PATCH v5 04/12] t0002: abstract away SHA-1 specific constants brian m. carlson
2018-09-13 5:17 ` [PATCH v5 05/12] t0027: make hash size independent brian m. carlson
2018-09-13 5:17 ` [PATCH v5 06/12] t0064: " brian m. carlson
2018-09-13 5:17 ` [PATCH v5 07/12] t1006: " brian m. carlson
2018-09-13 5:17 ` [PATCH v5 08/12] t1400: switch hard-coded object ID to variable brian m. carlson
2018-09-13 5:17 ` [PATCH v5 09/12] t1405: make hash size independent brian m. carlson
2018-09-13 5:17 ` [PATCH v5 10/12] t1406: make hash-size independent brian m. carlson
2018-09-13 5:17 ` [PATCH v5 11/12] t1407: make hash size independent brian m. carlson
2018-09-13 19:06 ` Ævar Arnfjörð Bjarmason
2018-09-13 5:17 ` [PATCH v5 12/12] t5318: use test_oid for HASH_LEN brian m. carlson
2018-09-13 17:00 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abd21e68-ac72-3111-5813-7d47af3d6aa6@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).