git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philip Oakley <philipoakley@iee.org>
To: "Alban Gruin" <alban.gruin@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: Why is there still git-rebase--am.sh?
Date: Sun, 2 Jun 2019 12:19:08 +0100	[thread overview]
Message-ID: <ab655637-bb6d-436d-a822-31fa1a9495ed@iee.org> (raw)
In-Reply-To: <3322453.bNc8J3RWDa@andromeda>

Hi Alban,

On 02/06/2019 12:04, Alban Gruin wrote:
> Hi,
>
> I was wandering in rebase’s source code, and found out that even though
> run_specific_rebase() no longer calls git-rebase--am.sh since 21853626ea
> ("built-in rebase: call `git am` directly", 2019-01-18), this commit did not
> remove the code to call it.  I guess it was an oversight.
>
> Now that git-legacy-rebase.sh is gone (since d03ebd411c, "rebase: remove the
> rebase.useBuiltin setting", 2019-03-18), I would expect this file to be
> completely removed, too.
>
> May I send a patch to remove git-rebase--am.sh, or is there a reason to keep
> it?
>
>
What's cooking (May 2019, #05; Thu, 30) has it in js/rebase-cleanup 
(2019-05-15) 5 commits, and will be cooked in next.
Philip

      reply	other threads:[~2019-06-02 11:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-02 11:04 Why is there still git-rebase--am.sh? Alban Gruin
2019-06-02 11:19 ` Philip Oakley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab655637-bb6d-436d-a822-31fa1a9495ed@iee.org \
    --to=philipoakley@iee.org \
    --cc=alban.gruin@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).