From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 9B22A1F4D8 for ; Sun, 8 May 2022 15:35:53 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Sc2wZlQH"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234690AbiEHPhp (ORCPT ); Sun, 8 May 2022 11:37:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234013AbiEHPho (ORCPT ); Sun, 8 May 2022 11:37:44 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B70AE03D for ; Sun, 8 May 2022 08:33:53 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id k2so9422563qtp.1 for ; Sun, 08 May 2022 08:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5icwPKC63crjEJDtNH/79PVDLbwLPOer8WrVfWzycqg=; b=Sc2wZlQHqmyZRpRACRHNqkPfKiceKVPlISQA0FS6g57HAaURS7hsDkT3yFfZ8gx2zV IOXYoScfNHFFdFVsCILgNOeAskLQeCvY2gz9X5VKDsnlihPqB1lCyc7OVnkqiDw0scbX wVsm9dSfPU0f9ggPLwEO7GBWu5TK6FWC/3WF5lwPWSmuHgrhektutvZP6Hffi/P0RIPD XpJ1hctOO5V73cqG7hSUKJNOCsi79l/srJgWeILNwXZV+3VZMsN4XjG7FxuY84D79iJZ Cmt17VIKUjJVUFQSn7SNYUql8ZBnftmvtelhIDeNdvU+dw7p8lOojtOQycHaeXGooXf5 xwhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5icwPKC63crjEJDtNH/79PVDLbwLPOer8WrVfWzycqg=; b=6RDA+SFxW4t5bHlmG+FWvVnnDtgqNtZqsk6NFhw+GvTZp7IjHx+jffdX2NWmLGjiwa B09n8NAiM94Rt775kL+m7cmvbfil/voHDTIT8wXYpVjcqetyswCaacsv+nAxcf82+5sL XtZM98y1DaPAGIbOIY1tfzAF/C5+ey4FKY+8VYQiE767QHb//9aCPi/2bo5Z000/sAl9 9Zh2a8YKFPF8a6UrMR3J2CsHw/Q2MKnVG0kfZGxyvNnZ0rxhDV4IeICyDwGPtKqlHJ4q vIXEIXsGmZYS7QbktbBB0TheA+PySAlFrG2YF6cXeqSBi2HJjMR4oyDfxfSiOgNM7syB vwPQ== X-Gm-Message-State: AOAM5313pXQNcFg6XPXSMYyLZVEwpIUWAoK2wZob9D3l1mPhnwm9zfgl 1/Hq5UX+yzaN9midEP/cBuIa7m3Vwi8= X-Google-Smtp-Source: ABdhPJymVCj1hyM6f3xTtWLz4cMdBIFR/fbA8Dx6sl36lGgvZM+JQXmtXMh95454qSOueJPczd1QZw== X-Received: by 2002:a05:622a:82:b0:2f3:b5de:4d2d with SMTP id o2-20020a05622a008200b002f3b5de4d2dmr11485968qtw.144.1652024032720; Sun, 08 May 2022 08:33:52 -0700 (PDT) Received: from [192.168.1.127] (173-246-5-136.qc.cable.ebox.net. [173.246.5.136]) by smtp.gmail.com with ESMTPSA id i22-20020ae9ee16000000b0069fc13ce1e5sm5494671qkg.22.2022.05.08.08.33.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 May 2022 08:33:52 -0700 (PDT) Subject: Re: [PATCH v3] builtin/remote.c: teach `-v` to list filters for promisor remotes To: Abhradeep Chakraborty via GitGitGadget , git@vger.kernel.org Cc: Philip Oakley , Junio C Hamano , Abhradeep Chakraborty References: From: Philippe Blain Message-ID: Date: Sun, 8 May 2022 11:33:51 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Abhradeep, Le 2022-05-07 à 10:20, Abhradeep Chakraborty via GitGitGadget a écrit : > From: Abhradeep Chakraborty > > `git remote -v` (`--verbose`) lists down the names of remotes along with > their urls. small nit: I would capitalize URLs. > It would be beneficial for users to also specify the filter > types for promisor remotes. Something like this - > > origin remote-url (fetch) [blob:none] > origin remote-url (push) > > Teach `git remote -v` to also specify the filters for promisor remotes. > > Signed-off-by: Abhradeep Chakraborty > --- > builtin/remote.c: teach -v to list filters for promisor remotes > > Fixes #1211 [1] I don't think this matters much, but if Junio is OK with that, it would be nice to include the reference to the GitGitGadget issue in the commit message itself, though with its full URL, something like: Closes: https://github.com/gitgitgadget/git/issues/1211 as another trailer before your signed-off-by. By including it in the commit message we allow the issue to be closed automatically when your topic branch is merged to 'master'. By using the full link we make sure that GitHub knows we are targetting that issue specifically, not any other issue or PR in any fork of Git with the same number. > > In the previous version, documentation is updated (describing the > proposed change) and url_buf is renamed into remote_info_buf. In this > varsion, some more test cases are added and broken indentations are > fixed. Again, small nit to make it easier for reviewers: usually we prefer to see what has changed since the previous version first, and then (if you want, it's not strictly necessary) what changed in the other previous versions. It's not necessary since if we want that info we can refer to the cover letters of the previous iterations directly. And ideally, in bullet points. So something like: Changes since v2: - added more test cases - fixed broken indentations Changes since v1: - updated documentation - renamed url_buf into remote_info_buf > > [1] https://github.com/gitgitgadget/git/issues/1211 > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1227%2FAbhra303%2Fpromisor_remote-v3 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1227/Abhra303/promisor_remote-v3 > Pull-Request: https://github.com/gitgitgadget/git/pull/1227 Thanks, Philippe.