From: Jeff Hostetler <git@jeffhostetler.com>
To: Josh Steadmon <steadmon@google.com>, git@vger.kernel.org
Subject: Re: [PATCH] trace2: teach Git to log environment variables
Date: Mon, 23 Mar 2020 11:28:16 -0400 [thread overview]
Message-ID: <aa4d22be-3710-1377-97aa-8ce8cfde0e20@jeffhostetler.com> (raw)
In-Reply-To: <0f5607a4242cc7b61ad36d0782c9d1250c4d4d7d.1584737973.git.steadmon@google.com>
On 3/20/20 5:06 PM, Josh Steadmon wrote:
> Via trace2, Git can already log interesting config parameters (see the
> trace2_cmd_list_config() function). However, this can grant an
> incomplete picture because many config parameters also allow overrides
> via environment variables.
>
> To allow for more complete logs, we add a new trace2_cmd_list_env_vars()
> function and supporting implementation, modeled after the pre-existing
> config param logging implementation.
>
> Signed-off-by: Josh Steadmon <steadmon@google.com>
> ---
> As I mentioned in the commit message, I modeled this pretty closely on
> the config parameter reporting code. It may make sense to split some of
> this out into its own file, particularly the parts in trace2/tr2_cfg.c.
> Alternatively, we could also just make the env var reporting part of the
> config param reporting. Let me know if you have a preference either way.
>
Looks good to me.
Jeff
next prev parent reply other threads:[~2020-03-23 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 21:06 [PATCH] trace2: teach Git to log environment variables Josh Steadmon
2020-03-20 21:21 ` Junio C Hamano
2020-03-23 15:28 ` Jeff Hostetler [this message]
2020-03-23 20:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa4d22be-3710-1377-97aa-8ce8cfde0e20@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).