git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Peter Oliver <p.d.oliver@mavit.org.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] doc: point to diff attribute in patch format docs
Date: Tue, 27 Apr 2021 11:37:44 +0100 (BST)	[thread overview]
Message-ID: <aa421f19-2ac5-570-61a0-100fa526423@froglet.home.mavit.org.uk> (raw)
In-Reply-To: <xmqqh7jsdvlb.fsf@gitster.g>

On Tue, 27 Apr 2021, Junio C Hamano wrote:

> "Peter Oliver via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> +5.  Hunk headers mention the name of the function to which the hunk
>> +    applies.  See linkgit:gitattributes[5] for details of how to tailor
>> +    to this to specific languages.
>
> Shouldn't this part be as helpful as the change you made to the
> earlier part by mentioning that the user wants to look at a specific
> part of the document, instead of reading the entire gitattributes(5)
> manpage?  Perhaps "Defining a custom hunk header" section is what
> they want to refer to.

Thanks, good suggestion.

-- 
Peter Oliver

  reply	other threads:[~2021-04-27 10:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 18:59 [PATCH] doc: point to diff attribute in patch format docs Peter Oliver via GitGitGadget
2021-04-27  7:40 ` Junio C Hamano
2021-04-27 10:37   ` Peter Oliver [this message]
2021-04-27 11:02 ` [PATCH v2] " Peter Oliver via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa421f19-2ac5-570-61a0-100fa526423@froglet.home.mavit.org.uk \
    --to=p.d.oliver@mavit.org.uk \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).