From: Derrick Stolee <stolee@gmail.com> To: Elijah Newren <newren@gmail.com>, Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> Cc: Git Mailing List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>, Matheus Tavares Bernardino <matheus.bernardino@usp.br>, Derrick Stolee <derrickstolee@github.com>, Derrick Stolee <dstolee@microsoft.com> Subject: Re: [PATCH v3 11/12] wt-status: expand added sparse directory entries Date: Tue, 18 May 2021 14:26:28 -0400 [thread overview] Message-ID: <a96b5081-e913-22a8-45eb-8d5de432dccb@gmail.com> (raw) In-Reply-To: <CABPp-BGww6VPMmp9dDyRJ2vgNCOdj16-LjU3aM3MM1NQ+T-pmg@mail.gmail.com> On 5/17/2021 10:27 PM, Elijah Newren wrote: > On Fri, May 14, 2021 at 11:31 AM Derrick Stolee via GitGitGadget > <gitgitgadget@gmail.com> wrote: >> >> From: Derrick Stolee <dstolee@microsoft.com> >> >> It is difficult, but possible, to get into a state where we intend to >> add a directory that is outside of the sparse-checkout definition. Add a > > Then we need to fix that; allowing things to be added outside the > sparse-checkout definition is a bug[1][2]. That's an invariant I > believe we should maintain everywhere; things get really confusing to > users somewhere later down the road if we don't. Matheus worked to > fix that with 'git add'; if there are other commands that need fixing > too, then we should also fix them. > > [1] https://lore.kernel.org/git/CABPp-BFhyFiKSXdLM5q5t=ZKzr6V0pY7dbheierRaOHFbMEdkg@mail.gmail.com/ > [2] https://lore.kernel.org/git/CABPp-BF0ZhbSs42R3Bw_r-hbhQ71qtbXSBqXdq0djyaan=8p=A@mail.gmail.com/ > >> test to t1092-sparse-checkout-compatibility.sh that demonstrates this >> using a combination of 'git reset --mixed' and 'git checkout --orphan'. > > I think `git checkout --orphan` should just throw an error if > sparse-checkout is in use. Allowing adding paths outside the > sparse-checkout set causes too much collateral and deferred confusion > for users. I've been trying to strike an interesting balance of creating performance improvements without changing behavior, trying to defer those behavior changes to an isolated instance. I think that approach is unavoidable with the 'git add' work that I pulled out of this series and will return to soon. However, here I think it would be too much to start throwing an error in this case. I think that change is a bit too much. The thing I can try to do, instead of the current approach, is to not allow sparse directory entries to differ between the index and HEAD. That will satisfy this case, but also a lot of other painful cases. I have no idea how to actually accomplish that, but I'll start digging. >> This test failed before because the output of 'git status >> --porcelain=v2' would not match on the lines for folder1/: >> >> * The sparse-checkout repo (with a full index) would output each path >> name that is intended to be added. >> >> * The sparse-index repo would only output that "folder1/" is staged for >> addition. >> >> The status should report the full list of files to be added, and so this >> sparse-directory entry should be expanded to a full list when reaching >> it inside the wt_status_collect_changes_initial() method. Use >> read_tree_at() to assist. > > Having a sparse directory entry whose object_id in the index does not > match HEAD should be an error. I can get behind this understanding. > Have a CE_SKIP_WORKTREE non-directory > whose object_id in the index does not match HEAD should also be an > error. I'm less convinced here. At minimum, I'm not willing to stake a firm claim and change the behavior around this statement in the current series. > I don't think we should complicate the code to try to handle > violations of those assumptions. I do think we should add checks to > enforce that constraint (or BUG() if it's violated). A BUG() is likely too strict, because existing Git clients can get users into this state, and then they upgrade and are suddenly in a BUG() state. We should perhaps do our best effort to avoid this case and handle it as appropriately as possible. > And yeah, that also means 'git sparse-checkout add/set' would need to > error out if paths are requested to be sparsified despite being > different from HEAD. This would be a reasonable thing, assuming the established behavior is changed. >> Somehow, this loop over the cache entries was not guarded by >> ensure_full_index() as intended. >> >> Signed-off-by: Derrick Stolee <dstolee@microsoft.com> >> --- >> t/t1092-sparse-checkout-compatibility.sh | 28 +++++++++++++ >> wt-status.c | 50 ++++++++++++++++++++++++ >> 2 files changed, 78 insertions(+) >> >> diff --git a/t/t1092-sparse-checkout-compatibility.sh b/t/t1092-sparse-checkout-compatibility.sh >> index 59faf7381093..cd3669d36b53 100755 >> --- a/t/t1092-sparse-checkout-compatibility.sh >> +++ b/t/t1092-sparse-checkout-compatibility.sh >> @@ -492,4 +492,32 @@ test_expect_success 'sparse-index is not expanded' ' >> test_region ! index ensure_full_index trace2.txt >> ' >> >> +test_expect_success 'reset mixed and checkout orphan' ' >> + init_repos && >> + >> + test_all_match git checkout rename-out-to-in && >> + test_all_match git reset --mixed HEAD~1 && >> + test_sparse_match test-tool read-cache --table --expand && >> + test_all_match git status --porcelain=v2 && >> + test_all_match git status --porcelain=v2 && >> + >> + # At this point, sparse-checkouts behave differently >> + # from the full-checkout. >> + test_sparse_match git checkout --orphan new-branch && >> + test_sparse_match test-tool read-cache --table --expand && >> + test_sparse_match git status --porcelain=v2 && >> + test_sparse_match git status --porcelain=v2 >> +' >> + >> +test_expect_success 'add everything with deep new file' ' >> + init_repos && >> + >> + run_on_sparse git sparse-checkout set deep/deeper1/deepest && >> + >> + run_on_all touch deep/deeper1/x && >> + test_all_match git add . && >> + test_all_match git status --porcelain=v2 && >> + test_all_match git status --porcelain=v2 >> +'> > This was a really nice catch that you got this particular testcase. > While I disagree with the fix, I do have to say nice work on the catch > and the implementation otherwise. This test exists almost verbatim in the Scalar and VFS For Git functional tests. I have no idea what context caused it to be necessary. I can understand your aversion to the solution I presented here. Preventing sparse directory entries that differ from the tree at HEAD for that path should be more robust to future integrations. Thanks, -Stolee
next prev parent reply other threads:[~2021-05-18 18:26 UTC|newest] Thread overview: 215+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-13 14:01 [PATCH 00/10] Sparse-index: integrate with status and add Derrick Stolee via GitGitGadget 2021-04-13 14:01 ` [PATCH 01/10] t1092: add tests for status/add and sparse files Derrick Stolee via GitGitGadget 2021-04-20 21:52 ` Elijah Newren 2021-04-21 13:21 ` Derrick Stolee 2021-04-21 15:14 ` Matheus Tavares Bernardino 2021-04-23 20:12 ` Derrick Stolee 2021-04-13 14:01 ` [PATCH 02/10] unpack-trees: make sparse aware Derrick Stolee via GitGitGadget 2021-04-20 23:00 ` Elijah Newren 2021-04-21 13:41 ` Derrick Stolee 2021-04-21 16:11 ` Elijah Newren 2021-04-22 2:24 ` Matheus Tavares Bernardino 2021-04-21 17:27 ` Derrick Stolee 2021-04-21 18:55 ` Matheus Tavares Bernardino 2021-04-21 19:10 ` Elijah Newren 2021-04-21 19:51 ` Matheus Tavares Bernardino 2021-04-21 18:56 ` Elijah Newren 2021-04-23 20:16 ` Derrick Stolee 2021-04-13 14:01 ` [PATCH 03/10] dir.c: accept a directory as part of cone-mode patterns Derrick Stolee via GitGitGadget 2021-04-20 23:21 ` Elijah Newren 2021-04-21 13:47 ` Derrick Stolee 2021-04-13 14:01 ` [PATCH 04/10] status: skip sparse-checkout percentage with sparse-index Derrick Stolee via GitGitGadget 2021-04-20 23:26 ` Elijah Newren 2021-04-21 13:51 ` Derrick Stolee 2021-04-13 14:01 ` [PATCH 05/10] status: use sparse-index throughout Derrick Stolee via GitGitGadget 2021-04-21 0:44 ` Elijah Newren 2021-04-21 13:55 ` Derrick Stolee 2021-04-13 14:01 ` [PATCH 06/10] dir: use expand_to_path() for sparse directories Derrick Stolee via GitGitGadget 2021-04-21 0:52 ` Elijah Newren 2021-04-21 0:53 ` Elijah Newren 2021-04-21 14:03 ` Derrick Stolee 2021-04-13 14:01 ` [PATCH 07/10] add: allow operating on a sparse-only index Derrick Stolee via GitGitGadget 2021-04-13 14:01 ` [PATCH 08/10] pathspec: stop calling ensure_full_index Derrick Stolee via GitGitGadget 2021-04-21 0:57 ` Elijah Newren 2021-04-13 14:01 ` [PATCH 09/10] t7519: add sparse directories to FS monitor tests Derrick Stolee via GitGitGadget 2021-04-13 14:01 ` [PATCH 10/10] fsmonitor: test with sparse index Derrick Stolee via GitGitGadget 2021-04-21 7:00 ` Elijah Newren 2021-04-13 20:45 ` [PATCH 00/10] Sparse-index: integrate with status and add Matheus Tavares Bernardino 2021-04-14 16:31 ` Derrick Stolee 2021-04-23 21:34 ` [PATCH v2 0/8] Sparse-index: integrate with status Derrick Stolee via GitGitGadget 2021-04-23 21:34 ` [PATCH v2 1/8] t1092: add tests for status/add and sparse files Derrick Stolee via GitGitGadget 2021-05-13 12:40 ` Matheus Tavares Bernardino 2021-05-14 12:27 ` Derrick Stolee 2021-04-23 21:34 ` [PATCH v2 2/8] unpack-trees: preserve cache_bottom Derrick Stolee via GitGitGadget 2021-04-23 21:34 ` [PATCH v2 3/8] unpack-trees: compare sparse directories correctly Derrick Stolee via GitGitGadget 2021-05-13 3:26 ` Elijah Newren 2021-04-23 21:34 ` [PATCH v2 4/8] unpack-trees: stop recursing into sparse directories Derrick Stolee via GitGitGadget 2021-05-13 3:31 ` Elijah Newren 2021-04-23 21:34 ` [PATCH v2 5/8] dir.c: accept a directory as part of cone-mode patterns Derrick Stolee via GitGitGadget 2021-04-23 21:34 ` [PATCH v2 6/8] status: skip sparse-checkout percentage with sparse-index Derrick Stolee via GitGitGadget 2021-04-23 21:34 ` [PATCH v2 7/8] status: use sparse-index throughout Derrick Stolee via GitGitGadget 2021-04-23 21:34 ` [PATCH v2 8/8] fsmonitor: test with sparse index Derrick Stolee via GitGitGadget 2021-05-13 4:12 ` [PATCH v2 0/8] Sparse-index: integrate with status Elijah Newren 2021-05-14 18:28 ` Derrick Stolee 2021-05-14 18:30 ` [PATCH v3 00/12] " Derrick Stolee via GitGitGadget 2021-05-14 18:31 ` [PATCH v3 01/12] sparse-index: skip indexes with unmerged entries Derrick Stolee via GitGitGadget 2021-05-14 18:31 ` [PATCH v3 02/12] sparse-index: include EXTENDED flag when expanding Derrick Stolee via GitGitGadget 2021-05-18 1:33 ` Elijah Newren 2021-05-18 14:57 ` Derrick Stolee 2021-05-18 17:48 ` Elijah Newren 2021-05-18 18:16 ` Derrick Stolee 2021-05-14 18:31 ` [PATCH v3 03/12] t1092: expand repository data shape Derrick Stolee via GitGitGadget 2021-05-18 1:49 ` Elijah Newren 2021-05-18 14:59 ` Derrick Stolee 2021-05-14 18:31 ` [PATCH v3 04/12] t1092: add tests for status/add and sparse files Derrick Stolee via GitGitGadget 2021-05-14 18:31 ` [PATCH v3 05/12] unpack-trees: preserve cache_bottom Derrick Stolee via GitGitGadget 2021-05-14 18:31 ` [PATCH v3 06/12] unpack-trees: compare sparse directories correctly Derrick Stolee via GitGitGadget 2021-05-14 18:31 ` [PATCH v3 07/12] unpack-trees: stop recursing into sparse directories Derrick Stolee via GitGitGadget 2021-05-18 2:03 ` Elijah Newren 2021-05-18 2:06 ` Elijah Newren 2021-05-18 19:20 ` Derrick Stolee 2021-05-14 18:31 ` [PATCH v3 08/12] dir.c: accept a directory as part of cone-mode patterns Derrick Stolee via GitGitGadget 2021-05-14 18:31 ` [PATCH v3 09/12] status: skip sparse-checkout percentage with sparse-index Derrick Stolee via GitGitGadget 2021-05-14 18:31 ` [PATCH v3 10/12] status: use sparse-index throughout Derrick Stolee via GitGitGadget 2021-05-14 18:31 ` [PATCH v3 11/12] wt-status: expand added sparse directory entries Derrick Stolee via GitGitGadget 2021-05-18 2:27 ` Elijah Newren 2021-05-18 18:26 ` Derrick Stolee [this message] 2021-05-18 19:04 ` Derrick Stolee 2021-05-19 8:38 ` Elijah Newren 2021-05-14 18:31 ` [PATCH v3 12/12] fsmonitor: integrate with sparse index Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 00/12] Sparse-index: integrate with status Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 01/12] sparse-index: skip indexes with unmerged entries Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 02/12] sparse-index: include EXTENDED flag when expanding Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 03/12] t1092: expand repository data shape Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 04/12] t1092: add tests for status/add and sparse files Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 05/12] unpack-trees: preserve cache_bottom Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 06/12] unpack-trees: compare sparse directories correctly Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 07/12] unpack-trees: be careful around sparse directory entries Derrick Stolee via GitGitGadget 2021-05-28 11:36 ` Derrick Stolee 2021-05-21 11:59 ` [PATCH v4 08/12] dir.c: accept a directory as part of cone-mode patterns Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 09/12] status: skip sparse-checkout percentage with sparse-index Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 10/12] status: use sparse-index throughout Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 11/12] wt-status: expand added sparse directory entries Derrick Stolee via GitGitGadget 2021-05-21 11:59 ` [PATCH v4 12/12] fsmonitor: integrate with sparse index Derrick Stolee via GitGitGadget 2021-06-07 12:33 ` [PATCH v5 00/14] Sparse-index: integrate with status Derrick Stolee via GitGitGadget 2021-06-07 12:33 ` [PATCH v5 01/14] sparse-index: skip indexes with unmerged entries Derrick Stolee via GitGitGadget 2021-06-07 12:34 ` [PATCH v5 02/14] sparse-index: include EXTENDED flag when expanding Derrick Stolee via GitGitGadget 2021-06-08 18:56 ` Elijah Newren 2021-06-09 17:39 ` Derrick Stolee 2021-06-09 18:11 ` Elijah Newren 2021-06-07 12:34 ` [PATCH v5 03/14] t1092: replace incorrect 'echo' with 'cat' Derrick Stolee via GitGitGadget 2021-06-08 19:18 ` Elijah Newren 2021-06-07 12:34 ` [PATCH v5 04/14] t1092: expand repository data shape Derrick Stolee via GitGitGadget 2021-06-07 12:34 ` [PATCH v5 05/14] t1092: add tests for status/add and sparse files Derrick Stolee via GitGitGadget 2021-06-07 12:34 ` [PATCH v5 06/14] unpack-trees: preserve cache_bottom Derrick Stolee via GitGitGadget 2021-06-07 12:34 ` [PATCH v5 07/14] unpack-trees: compare sparse directories correctly Derrick Stolee via GitGitGadget 2021-06-07 12:34 ` [PATCH v5 08/14] unpack-trees: unpack sparse directory entries Derrick Stolee via GitGitGadget 2021-06-09 3:48 ` Elijah Newren 2021-06-09 20:21 ` Derrick Stolee 2021-06-07 12:34 ` [PATCH v5 09/14] dir.c: accept a directory as part of cone-mode patterns Derrick Stolee via GitGitGadget 2021-06-07 12:34 ` [PATCH v5 10/14] diff-lib: handle index diffs with sparse dirs Derrick Stolee via GitGitGadget 2021-06-07 15:26 ` Derrick Stolee 2021-06-08 1:05 ` Junio C Hamano 2021-06-08 13:00 ` Derrick Stolee 2021-06-09 5:47 ` Elijah Newren 2021-06-09 6:32 ` Junio C Hamano 2021-06-09 8:11 ` Elijah Newren 2021-06-09 20:33 ` Derrick Stolee 2021-06-10 17:45 ` Derrick Stolee 2021-06-10 21:31 ` Elijah Newren 2021-06-11 12:57 ` Derrick Stolee 2021-06-11 17:27 ` Derrick Stolee 2021-06-07 12:34 ` [PATCH v5 11/14] status: skip sparse-checkout percentage with sparse-index Derrick Stolee via GitGitGadget 2021-06-07 12:34 ` [PATCH v5 12/14] status: use sparse-index throughout Derrick Stolee via GitGitGadget 2021-06-07 12:34 ` [PATCH v5 13/14] wt-status: expand added sparse directory entries Derrick Stolee via GitGitGadget 2021-06-09 5:27 ` Elijah Newren 2021-06-09 20:49 ` Derrick Stolee 2021-06-07 12:34 ` [PATCH v5 14/14] fsmonitor: integrate with sparse index Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 00/14] Sparse-index: integrate with status Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 01/14] sparse-index: skip indexes with unmerged entries Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 02/14] sparse-index: include EXTENDED flag when expanding Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 03/14] t1092: replace incorrect 'echo' with 'cat' Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 04/14] t1092: expand repository data shape Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 05/14] t1092: add tests for status/add and sparse files Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 06/14] unpack-trees: preserve cache_bottom Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 07/14] unpack-trees: compare sparse directories correctly Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 08/14] unpack-trees: unpack sparse directory entries Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 09/14] dir.c: accept a directory as part of cone-mode patterns Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 10/14] diff-lib: handle index diffs with sparse dirs Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 11/14] status: skip sparse-checkout percentage with sparse-index Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 12/14] status: use sparse-index throughout Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 13/14] wt-status: expand added sparse directory entries Derrick Stolee via GitGitGadget 2021-06-29 1:51 ` [PATCH v6 14/14] fsmonitor: integrate with sparse index Derrick Stolee via GitGitGadget 2021-06-29 2:02 ` [PATCH v6 00/14] Sparse-index: integrate with status Derrick Stolee 2021-06-29 2:04 ` [PATCH v7 00/16] " Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 01/16] sparse-index: skip indexes with unmerged entries Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 02/16] sparse-index: include EXTENDED flag when expanding Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 03/16] t1092: replace incorrect 'echo' with 'cat' Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 04/16] t1092: expand repository data shape Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 05/16] t1092: add tests for status/add and sparse files Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 06/16] unpack-trees: preserve cache_bottom Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 07/16] unpack-trees: compare sparse directories correctly Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 08/16] unpack-trees: rename unpack_nondirectories() Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 09/16] unpack-trees: unpack sparse directory entries Derrick Stolee via GitGitGadget 2021-07-07 22:25 ` Elijah Newren 2021-06-29 2:04 ` [PATCH v7 10/16] unpack-trees: handle dir/file conflict of sparse entries Derrick Stolee via GitGitGadget 2021-07-07 23:19 ` Elijah Newren 2021-07-09 0:58 ` Elijah Newren 2021-07-12 13:46 ` Derrick Stolee 2021-06-29 2:04 ` [PATCH v7 11/16] dir.c: accept a directory as part of cone-mode patterns Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 12/16] diff-lib: handle index diffs with sparse dirs Derrick Stolee via GitGitGadget 2021-07-08 23:10 ` Elijah Newren 2021-07-08 23:51 ` Elijah Newren 2021-07-12 13:52 ` Derrick Stolee 2021-06-29 2:04 ` [PATCH v7 13/16] status: skip sparse-checkout percentage with sparse-index Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 14/16] status: use sparse-index throughout Derrick Stolee via GitGitGadget 2021-06-29 2:04 ` [PATCH v7 15/16] wt-status: expand added sparse directory entries Derrick Stolee via GitGitGadget 2021-07-09 1:03 ` Elijah Newren 2021-07-12 13:56 ` Derrick Stolee 2021-07-12 19:32 ` Elijah Newren 2021-07-12 19:41 ` Derrick Stolee 2021-06-29 2:04 ` [PATCH v7 16/16] fsmonitor: integrate with sparse index Derrick Stolee via GitGitGadget 2021-06-29 2:16 ` [PATCH v7 00/16] Sparse-index: integrate with status Derrick Stolee 2021-06-30 14:32 ` Elijah Newren 2021-07-09 1:16 ` Elijah Newren 2021-07-12 14:46 ` Derrick Stolee 2021-07-12 17:55 ` [PATCH v8 00/15] " Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 01/15] sparse-index: skip indexes with unmerged entries Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 02/15] sparse-index: include EXTENDED flag when expanding Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 03/15] t1092: replace incorrect 'echo' with 'cat' Derrick Stolee via GitGitGadget 2021-07-14 0:02 ` Bagas Sanjaya 2021-07-12 17:55 ` [PATCH v8 04/15] t1092: expand repository data shape Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 05/15] t1092: add tests for status/add and sparse files Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 06/15] unpack-trees: preserve cache_bottom Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 07/15] unpack-trees: compare sparse directories correctly Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 08/15] unpack-trees: rename unpack_nondirectories() Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 09/15] unpack-trees: unpack sparse directory entries Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 10/15] dir.c: accept a directory as part of cone-mode patterns Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 11/15] diff-lib: handle index diffs with sparse dirs Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 12/15] status: skip sparse-checkout percentage with sparse-index Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 13/15] status: use sparse-index throughout Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 14/15] wt-status: expand added sparse directory entries Derrick Stolee via GitGitGadget 2021-07-12 17:55 ` [PATCH v8 15/15] fsmonitor: integrate with sparse index Derrick Stolee via GitGitGadget 2021-07-12 19:38 ` [PATCH v8 00/15] Sparse-index: integrate with status Elijah Newren 2021-07-13 12:57 ` Derrick Stolee 2021-07-13 17:37 ` Elijah Newren 2021-07-14 13:12 ` [PATCH v9 00/16] " Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 01/16] sparse-index: skip indexes with unmerged entries Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 02/16] sparse-index: include EXTENDED flag when expanding Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 03/16] t1092: replace incorrect 'echo' with 'cat' Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 04/16] t1092: expand repository data shape Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 05/16] t1092: add tests for status/add and sparse files Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 06/16] unpack-trees: preserve cache_bottom Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 07/16] unpack-trees: compare sparse directories correctly Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 08/16] unpack-trees: rename unpack_nondirectories() Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 09/16] unpack-trees: unpack sparse directory entries Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 10/16] dir.c: accept a directory as part of cone-mode patterns Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 11/16] diff-lib: handle index diffs with sparse dirs Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 12/16] status: skip sparse-checkout percentage with sparse-index Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 13/16] status: use sparse-index throughout Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 14/16] wt-status: expand added sparse directory entries Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 15/16] fsmonitor: integrate with sparse index Derrick Stolee via GitGitGadget 2021-07-14 13:12 ` [PATCH v9 16/16] t1092: document bad sparse-checkout behavior Derrick Stolee via GitGitGadget 2021-07-14 15:08 ` [PATCH v9 00/16] Sparse-index: integrate with status Elijah Newren 2021-07-14 20:37 ` Junio C Hamano 2021-07-15 2:41 ` Elijah Newren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a96b5081-e913-22a8-45eb-8d5de432dccb@gmail.com \ --to=stolee@gmail.com \ --cc=derrickstolee@github.com \ --cc=dstolee@microsoft.com \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=gitster@pobox.com \ --cc=matheus.bernardino@usp.br \ --cc=newren@gmail.com \ --subject='Re: [PATCH v3 11/12] wt-status: expand added sparse directory entries' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).