From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 255C11FE90 for ; Sat, 22 Apr 2017 13:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1043944AbdDVNhh (ORCPT ); Sat, 22 Apr 2017 09:37:37 -0400 Received: from bsmtp1.bon.at ([213.33.87.15]:32412 "EHLO bsmtp1.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1043939AbdDVNhe (ORCPT ); Sat, 22 Apr 2017 09:37:34 -0400 Received: from dx.site (unknown [93.83.142.38]) by bsmtp1.bon.at (Postfix) with ESMTPSA id 3w9DDq224Tz5tlJ; Sat, 22 Apr 2017 15:37:31 +0200 (CEST) Received: from [IPv6:::1] (localhost [IPv6:::1]) by dx.site (Postfix) with ESMTP id A1DB542D4; Sat, 22 Apr 2017 15:37:30 +0200 (CEST) Subject: Re: What's cooking in git.git (Apr 2017, #04; Wed, 19) To: Christian Couder References: Cc: Johannes Schindelin , Junio C Hamano , Lars Schneider , git , Jeff King , Brandon Williams From: Johannes Sixt Message-ID: Date: Sat, 22 Apr 2017 15:37:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Am 21.04.2017 um 14:29 schrieb Christian Couder: > First bisect should ask you to test merge bases only if there are > "good" commits that are not ancestors of the "bad" commit. That's a tangent, but I have never understood why this needs to be so. Consider this: o--o--o--o--o--o--o--o--B / / -o--o--o--o--g--o--o--o--o--G When I mark B as bad and G as good, why would g have to be tested first? This is exactly what I do when I bisect in Git history: I mark the latest commits on git-gui and gitk sub-histories as good, because I know they can't possibly be bad. (In my setup, these two histories are ahead of pu and next.) -- Hannes