From: Marc Branchaud <marcnarc@xiplink.com>
To: Sebastian Schuberth <sschuberth@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
Date: Fri, 3 Mar 2017 10:32:29 -0500 [thread overview]
Message-ID: <a9273d37-388a-8c27-1cf1-51e9cb28ef55@xiplink.com> (raw)
In-Reply-To: <0102015a93d18443-c574aaf8-5656-49e8-8848-810e1fadc87a-000000@eu-west-1.amazonses.com>
On 2017-03-03 05:57 AM, Sebastian Schuberth wrote:
> It does not make sense for these placeholder scripts to depend on Python
> just because the real scripts do. At the example of Git for Windows, we
> would not even be able to see those warnings as it does not ship with
> Python. So just use plain shell scripts instead.
Just a niggle: This change moves the warning message from stderr to stdout.
M.
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
> ---
> contrib/remote-helpers/git-remote-bzr | 16 +++++++---------
> contrib/remote-helpers/git-remote-hg | 16 +++++++---------
> 2 files changed, 14 insertions(+), 18 deletions(-)
>
> diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
> index 712a137..ccc4aea 100755
> --- a/contrib/remote-helpers/git-remote-bzr
> +++ b/contrib/remote-helpers/git-remote-bzr
> @@ -1,13 +1,11 @@
> -#!/usr/bin/env python
> +#!/bin/sh
>
> -import sys
> -
> -sys.stderr.write('WARNING: git-remote-bzr is now maintained independently.\n')
> -sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-bzr\n')
> -
> -sys.stderr.write('''WARNING:
> +cat <<'EOT'
> +WARNING: git-remote-bzr is now maintained independently.
> +WARNING: For more information visit https://github.com/felipec/git-remote-bzr
> +WARNING:
> WARNING: You can pick a directory on your $PATH and download it, e.g.:
> -WARNING: $ wget -O $HOME/bin/git-remote-bzr \\
> +WARNING: $ wget -O $HOME/bin/git-remote-bzr \
> WARNING: https://raw.github.com/felipec/git-remote-bzr/master/git-remote-bzr
> WARNING: $ chmod +x $HOME/bin/git-remote-bzr
> -''')
> +EOT
> diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
> index 4255ad6..dfda44f 100755
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -1,13 +1,11 @@
> -#!/usr/bin/env python
> +#!/bin/sh
>
> -import sys
> -
> -sys.stderr.write('WARNING: git-remote-hg is now maintained independently.\n')
> -sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-hg\n')
> -
> -sys.stderr.write('''WARNING:
> +cat <<'EOT'
> +WARNING: git-remote-hg is now maintained independently.
> +WARNING: For more information visit https://github.com/felipec/git-remote-hg
> +WARNING:
> WARNING: You can pick a directory on your $PATH and download it, e.g.:
> -WARNING: $ wget -O $HOME/bin/git-remote-hg \\
> +WARNING: $ wget -O $HOME/bin/git-remote-hg \
> WARNING: https://raw.github.com/felipec/git-remote-hg/master/git-remote-hg
> WARNING: $ chmod +x $HOME/bin/git-remote-hg
> -''')
> +EOT
>
> --
> https://github.com/git/git/pull/333
>
next prev parent reply other threads:[~2017-03-03 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 10:57 [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts Sebastian Schuberth
2017-03-03 11:21 ` Jeff King
2017-03-03 19:06 ` Junio C Hamano
2017-03-03 15:32 ` Marc Branchaud [this message]
2017-03-03 19:10 ` Junio C Hamano
2017-03-03 20:13 ` Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9273d37-388a-8c27-1cf1-51e9cb28ef55@xiplink.com \
--to=marcnarc@xiplink.com \
--cc=git@vger.kernel.org \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).