git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: Jeff King <peff@peff.net>
Cc: Dana Dahlstrom <dahlstrom@google.com>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/2] checkout: add tests for -b and --track
Date: Thu, 28 May 2020 15:53:42 +0200	[thread overview]
Message-ID: <a879b067-978c-aa9f-fb51-a9e717363544@web.de> (raw)
In-Reply-To: <20200527064056.GA4005121@coredump.intra.peff.net>

Am 27.05.20 um 08:40 schrieb Jeff King:
> On Sun, May 24, 2020 at 09:22:51AM +0200, René Scharfe wrote:
>
>> Test git checkout -b with and without --track and demonstrate unexpected
>> error messages when it's given an extra (i.e. unsupported) path
>> argument.  In both cases it reports:
>>
>>    $ git checkout -b foo origin/master bar
>>    fatal: 'bar' is not a commit and a branch 'foo' cannot be created from it
>>
>> The problem is that the start point we gave for the new branch is
>> "origin/master" and "bar" is just some extra argument -- it could even
>> be a valid commit, which would make the message even more confusing.  We
>> have more fitting error messages in git commit, but get confused; use
>> the text of the rights ones in the tests.
>
> Did you mean "more fitting error message in git checkout"?

Dang, yes, a typo -- it's all about checkout.

René

  reply	other threads:[~2020-05-28 13:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21 19:00 'HEAD' is not a commit (according to git-checkout) Dana Dahlstrom
2020-05-21 19:16 ` Jeff King
2020-05-23  7:07   ` René Scharfe
2020-05-23 16:29     ` Jeff King
2020-05-24  7:22       ` [PATCH 1/2] checkout: add tests for -b and --track René Scharfe
2020-05-27  6:40         ` Jeff King
2020-05-28 13:53           ` René Scharfe [this message]
2020-05-24  7:23       ` [PATCH 2/2] checkout: improve error messages for -b with extra argument René Scharfe
2020-05-27  6:42         ` Jeff King
2020-05-24  7:23       ` 'HEAD' is not a commit (according to git-checkout) René Scharfe
2020-05-24 16:15         ` Junio C Hamano
2020-05-27  6:52           ` Jeff King
2020-05-27 15:44             ` Junio C Hamano
2020-05-27 15:52               ` Randall S. Becker
2020-05-27 17:31                 ` Jeff King
2020-05-21 19:49 ` René Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a879b067-978c-aa9f-fb51-a9e717363544@web.de \
    --to=l.s.r@web.de \
    --cc=dahlstrom@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).