From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id B78C620248 for ; Wed, 17 Apr 2019 14:14:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732319AbfDQOOU (ORCPT ); Wed, 17 Apr 2019 10:14:20 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:50287 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731743AbfDQOOU (ORCPT ); Wed, 17 Apr 2019 10:14:20 -0400 Received: by mail-wm1-f65.google.com with SMTP id z11so3627598wmi.0 for ; Wed, 17 Apr 2019 07:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pqtnLiBTTDzoQTuJ6rD6yvOmjJhAO6TdpjRng1Qb140=; b=fBZK+fsLMSFDiMykyqIkoEFVXQX/9CBo7XQveyCVwT7GV5D+oumad1I5wkCGlhTzpV /hzkExcg/Y5Rs9yMuJ7X8Mnr7NZ1MX9G8Crw4UA6t43Uljp0Zf9isj1/KyF8x170bwUn IEqBA+xjrgVGklT/2uJEQAa2qys4+NLVZ+n7emcSz04PZOJdRdpw1OE8fdTOz+VabpqF FN/AEvtpY/yvZgukVQBMqd8SBt4B/aHhISz8TQYlO9JnjgdtLzhstzuJG74rjJfee0oR +t3fPN71YUnc2XFVh4Avg8xA3IBrD0wpz49ZgXhISZTjkBf+6Bm6Ij9DY8p3GOVKlohi 8IPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=pqtnLiBTTDzoQTuJ6rD6yvOmjJhAO6TdpjRng1Qb140=; b=AmCIdc9M9FNkeIqmoK4UD1Y+MZZMr4EfWIduPMzOdThtu7by4hCR5dFha1SBIrZHOF HO0JnCeRMP/q/crUKvkH5SD2pxOuMkM9ElN4rlkLKm6O9R/RbQ1jHN5V7bFvlax0+Nyp vVpAUXZP7I4hbxeH/Z6+sc4oxD95n19qB0gRu30eI9fdlBWsn6UdN6Bf/qR5XvawNq6z 1PTYVSrEjtuWLPSdAUbqmXbG7+dX1GHyTCIRM+q03W+sdqBABvEYapAoKcevzsySw32+ aAploiqt52TLwYXoHsVrfvOTRujmV11kI65eZHtdTosSbFlpGK6Wl1byd6cFap9MqFVU yi5Q== X-Gm-Message-State: APjAAAX7tZm8Q67lDUBc3XKAg+rcnJqCi+0xMxB0+wbt+VldVcE58H9z qh1Eh20JUtcf+bnU9EKYFbI= X-Google-Smtp-Source: APXvYqzssfl2ATu+wHKoGNGzSoPX39xmEeYRMNsq2hyu9Q8whrDAn1KNNiyNAswj5T11a+lRuNHswg== X-Received: by 2002:a1c:d1c5:: with SMTP id i188mr30121710wmg.8.1555510457302; Wed, 17 Apr 2019 07:14:17 -0700 (PDT) Received: from [192.168.2.240] (host-92-22-21-176.as13285.net. [92.22.21.176]) by smtp.gmail.com with ESMTPSA id x6sm3367928wro.81.2019.04.17.07.14.15 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 17 Apr 2019 07:14:16 -0700 (PDT) Reply-To: phillip.wood@dunelm.org.uk Subject: Re: [PATCH v5 3/5] rebase: fast-forward --onto in more cases To: Denton Liu , phillip.wood@dunelm.org.uk Cc: Git Mailing List , Eric Sunshine , Junio C Hamano , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Johannes Schindelin , Johannes Sixt , =?UTF-8?Q?SZEDER_G=c3=a1bor?= References: <216aa032-d28e-79ba-6bc7-c4bd3de4321d@gmail.com> <20190417064420.GA12818@archbookpro.localdomain> From: Phillip Wood Message-ID: Date: Wed, 17 Apr 2019 15:14:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190417064420.GA12818@archbookpro.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB-large Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 17/04/2019 07:44, Denton Liu wrote: > On Tue, Apr 16, 2019 at 02:59:12PM +0100, Phillip Wood wrote: >> Hi Denton >> >> It's good to see rebase fast-forwarding properly when it should >> >> On 15/04/2019 23:29, Denton Liu wrote: >>> Before, when we had the following graph, >>> >>> A---B---C (master) >>> \ >>> D (side) >>> >>> running 'git rebase --onto master... master side' would result in D >>> being always rebased, no matter what. However, the desired behavior is >>> that rebase should notice that this is fast-forwardable and do that >>> instead. >>> >>> Add detection to `can_fast_forward` so that this case can be detected >>> and a fast-forward will be performed. First of all, rewrite the function >>> to use gotos which simplifies the logic. Next, since the >>> >>> options.upstream && >>> !oidcmp(&options.upstream->object.oid, &options.onto->object.oid) >>> >>> conditions were removed in `cmd_rebase`, we reintroduce a substitute in >>> `can_fast_forward`. In particular, checking the merge bases of >>> `upstream` and `head` fixes a failing case in t3416. >>> >>> The abbreviated graph for t3416 is as follows: >>> >>> F---G topic >>> / >>> A---B---C---D---E master >>> >>> and the failing command was >>> >>> git rebase --onto master...topic F topic >>> >>> Before, Git would see that there was one merge base (C), and the merge >>> and onto were the same so it would incorrectly return 1, indicating that >>> we could fast-forward. This would cause the rebased graph to be 'ABCFG' >>> when we were expecting 'ABCG'. >>> >>> With the additional logic, we detect that upstream and head's merge base >>> is F. Since onto isn't F, it means we're not rebasing the full set of >>> commits from master..topic. Since we're excluding some commits, a >>> fast-forward cannot be performed and so we correctly return 0. >>> >>> Add '-f' to test cases that failed as a result of this change because >>> they were not expecting a fast-forward so that a rebase is forced. >>> >>> While we're at it, remove a trailing whitespace from rebase.c. >>> >>> Signed-off-by: Denton Liu >>> --- >>> builtin/rebase.c | 40 +++++++++++++++++++++++----------- >>> t/t3400-rebase.sh | 2 +- >>> t/t3404-rebase-interactive.sh | 2 +- >>> t/t3432-rebase-fast-forward.sh | 4 ++-- >>> 4 files changed, 31 insertions(+), 17 deletions(-) >>> >>> diff --git a/builtin/rebase.c b/builtin/rebase.c >>> index 77deebc65c..7aa6a090d4 100644 >>> --- a/builtin/rebase.c >>> +++ b/builtin/rebase.c >>> @@ -895,12 +895,12 @@ static int is_linear_history(struct commit *from, struct commit *to) >>> return 1; >>> } >>> -static int can_fast_forward(struct commit *onto, struct object_id *head_oid, >>> - struct object_id *merge_base) >>> +static int can_fast_forward(struct commit *onto, struct commit *upstream, >>> + struct object_id *head_oid, struct object_id *merge_base) >>> { >>> struct commit *head = lookup_commit(the_repository, head_oid); >>> - struct commit_list *merge_bases; >>> - int res; >>> + struct commit_list *merge_bases = NULL; >>> + int res = 0; >>> if (!head) >>> return 0; >>> @@ -908,12 +908,29 @@ static int can_fast_forward(struct commit *onto, struct object_id *head_oid, >>> merge_bases = get_merge_bases(onto, head); >>> if (merge_bases && !merge_bases->next) { >>> oidcpy(merge_base, &merge_bases->item->object.oid); >>> - res = oideq(merge_base, &onto->object.oid); >>> + if (!oideq(merge_base, &onto->object.oid)) >>> + goto done; >>> } else { >>> oidcpy(merge_base, &null_oid); >>> - res = 0; >>> + goto done; >>> } >>> + >>> + if (!upstream) >>> + goto done; >>> + >>> free_commit_list(merge_bases); >>> + merge_bases = get_merge_bases(upstream, head); >>> + if (merge_bases && !merge_bases->next) { >>> + if (!oideq(&onto->object.oid, &merge_bases->item->object.oid)) >>> + goto done; >>> + } else >>> + goto done; >>> + >>> + res = 1; >>> + >>> +done: >>> + if (merge_bases) >>> + free_commit_list(merge_bases); >>> return res && is_linear_history(onto, head); >>> } >> >> I had a hard time following all those gotos. When you 'goto done' in both >> branches of an if statement it is hard to work out which cases fall through >> to the rest of the code. If I've understood it correctly I think it is >> clearer as >> >> merge_bases = get_merge_bases(onto, head); >> if (merge_bases && !merge_bases->next) { >> oidcpy(merge_base, &merge_bases->item->object.oid); >> if (oideq(merge_base, &onto->object.oid) && upstream) { >> free_commit_list(merge_bases); >> merge_bases = get_merge_bases(upstream, head); >> if (merge_bases && !merge_bases->next) >> if (oideq(&onto->object.oid, >> &merge_bases->item->object.oid)) >> res = 1; that would be better as res = oideq(&onto->object.oid, &merge_bases->item->object.oid); without the last if >> } >> } else { >> oidcpy(merge_base, &null_oid); >> } >> >> if (merge_bases) >> free_commit_list(merge_bases); >> return res && is_linear_history(onto, head); >> } >> >> The nested if's aren't great but I think it is easier to follow > > I am pretty impartial between gotos and ifs. If no one else has any > strong opinions between the two, I'll reroll with ifs. If you want to keep the goto approach then refactoring the ifs as follows is clearer as it avoids jumping from both arms, each stage is a simple single armed if (something) goto done merge_bases = get_merge_bases(onto, head); if (!merge_bases || merge_bases->next) { oidcpy(merge_base, &null_oid); goto done; } oidcpy(merge_base, &merge_bases->item->object.oid); if (!oideq(merge_base, &onto->object.oid)) goto done; if (!upstream) goto done; free_commit_list(merge_bases); merge_bases = get_merge_bases(upstream, head); if (merge_bases && !merge_bases->next) res = oideq(&onto->object.oid, &merge_bases->item->object.oid); done: if (merge_bases) free_commit_list(merge_bases); return res && is_linear_history(onto, head); } Best Wishes Phillip >> >>> @@ -1682,13 +1699,10 @@ int cmd_rebase(int argc, const char **argv, const char *prefix) >>> /* >>> * Check if we are already based on onto with linear history, >>> - * but this should be done only when upstream and onto are the same >>> - * and if this is not an interactive rebase. >>> + * but this should be done if this is not an interactive rebase. >>> */ >>> - if (can_fast_forward(options.onto, &options.orig_head, &merge_base) && >>> - !is_interactive(&options) && !options.restrict_revision && >>> - options.upstream && >>> - !oidcmp(&options.upstream->object.oid, &options.onto->object.oid)) { >>> + if (can_fast_forward(options.onto, options.upstream, &options.orig_head, &merge_base) && >> >> This is rather long, perhaps break the argument list > > Thanks, will do. > >> >> Best Wishes >> >> Phillip >>> + !is_interactive(&options) && !options.restrict_revision) { >>> int flag; >>> if (!(options.flags & REBASE_FORCE)) { >>> @@ -1782,7 +1796,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix) >>> strbuf_addf(&msg, "%s: checkout %s", >>> getenv(GIT_REFLOG_ACTION_ENVIRONMENT), options.onto_name); >>> if (reset_head(&options.onto->object.oid, "checkout", NULL, >>> - RESET_HEAD_DETACH | RESET_ORIG_HEAD | >>> + RESET_HEAD_DETACH | RESET_ORIG_HEAD | >>> RESET_HEAD_RUN_POST_CHECKOUT_HOOK, >>> NULL, msg.buf)) >>> die(_("Could not detach HEAD")); >>> diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh >>> index 460d0523be..604d624ff8 100755 >>> --- a/t/t3400-rebase.sh >>> +++ b/t/t3400-rebase.sh >>> @@ -295,7 +295,7 @@ test_expect_success 'rebase--am.sh and --show-current-patch' ' >>> echo two >>init.t && >>> git commit -a -m two && >>> git tag two && >>> - test_must_fail git rebase --onto init HEAD^ && >>> + test_must_fail git rebase -f --onto init HEAD^ && >>> GIT_TRACE=1 git rebase --show-current-patch >/dev/null 2>stderr && >>> grep "show.*$(git rev-parse two)" stderr >>> ) >>> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh >>> index b60b11f9f2..f054186cc7 100755 >>> --- a/t/t3404-rebase-interactive.sh >>> +++ b/t/t3404-rebase-interactive.sh >>> @@ -1066,7 +1066,7 @@ test_expect_success C_LOCALE_OUTPUT 'rebase --edit-todo does not work on non-int >>> git reset --hard && >>> git checkout conflict-branch && >>> set_fake_editor && >>> - test_must_fail git rebase --onto HEAD~2 HEAD~ && >>> + test_must_fail git rebase -f --onto HEAD~2 HEAD~ && >>> test_must_fail git rebase --edit-todo && >>> git rebase --abort >>> ' >>> diff --git a/t/t3432-rebase-fast-forward.sh b/t/t3432-rebase-fast-forward.sh >>> index 4f04d67fd7..d0e5b1f3e6 100755 >>> --- a/t/t3432-rebase-fast-forward.sh >>> +++ b/t/t3432-rebase-fast-forward.sh >>> @@ -64,9 +64,9 @@ test_expect_success 'add work to upstream' ' >>> changes='our and their changes' >>> test_rebase_same_head success --onto B B >>> test_rebase_same_head success --onto B... B >>> -test_rebase_same_head failure --onto master... master >>> +test_rebase_same_head success --onto master... master >>> test_rebase_same_head failure --fork-point --onto B B >>> test_rebase_same_head failure --fork-point --onto B... B >>> -test_rebase_same_head failure --fork-point --onto master... master >>> +test_rebase_same_head success --fork-point --onto master... master >>> test_done >>>